From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5026 invoked by alias); 15 Apr 2005 23:38:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4986 invoked from network); 15 Apr 2005 23:38:04 -0000 Received: from unknown (HELO e35.co.us.ibm.com) (32.97.110.133) by sourceware.org with SMTP; 15 Apr 2005 23:38:04 -0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j3FNc3Lg375014 for ; Fri, 15 Apr 2005 19:38:03 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j3FNc3L8167520 for ; Fri, 15 Apr 2005 17:38:03 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j3FNc3wj017369 for ; Fri, 15 Apr 2005 17:38:03 -0600 Received: from dyn9047022123-009047022128.beaverton.ibm.com (dyn9047022123-009047022128.beaverton.ibm.com [9.47.22.128]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j3FNc3p0017351; Fri, 15 Apr 2005 17:38:03 -0600 From: Paul Gilliam Reply-To: pgilliam@us.ibm.com To: gdb-patches@sources.redhat.com Subject: [PATCH] Fixes testsuit/gdb.base/annota1.exp Date: Fri, 15 Apr 2005 23:38:00 -0000 User-Agent: KMail/1.6.2 Cc: Daniel Jacobowitz References: <200504071025.11668.pgilliam@us.ibm.com> <20050414193642.GB19792@nevyn.them.org> In-Reply-To: <20050414193642.GB19792@nevyn.them.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <200504151637.55773.pgilliam@us.ibm.com> X-SW-Source: 2005-04/txt/msg00176.txt.bz2 OK. =A0this is in partial responce to: =A0=A0=A0=A0=A0=A0=A0=A0http://sourceware.org/ml/gdb-patches/2005-04/msg001= 45.html There were two problems with gdb.base/annota1.exp. This patch is only for = the second one. The problem here is that a bug in backtrace was causing a false nagitive in= gdb.base/annota1.exp, so the feature being tested was OK, but was being failed due to some other = bug that caused the backtrace to not stop at the end. NOTE: this also allows for 'doc symbols' like '.printf'. I understand that= these are going away soon, but an extra '\.?' shouldn't hurt anything. -=3D# Paul #=3D- -- 2005-04-15 Paul Gilliam * gdb.base/annota1.exp: Deal with backtrace 'skidding' past top-of-stack due to a bug unrealted to annotation. Index: gdb.base/annota1.exp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v retrieving revision 1.16 diff -c -3 -p -r1.16 annota1.exp *** gdb.base/annota1.exp 20 Jul 2004 00:24:41 -0000 1.16 --- gdb.base/annota1.exp 21 Sep 2004 20:45:39 -0000 *************** send_gdb "backtrace\n" *** 254,259 **** --- 254,261 ---- gdb_expect { -re "\r\n\032\032post-prompt\r\n\r\n\032\032frame-begin 0 $hex\r\n.0 = \r\n(\032\032frame-address\r\n$hex\r\n\032\032frame-address-end\r\n in \r\= n)*\032\032frame-function-name\r\nprintf\r\n\032\032frame-args\r\n \\(.*fra= me-end\r\n\r\n\032\032frame-begin 1 $hex\r\n.1 \r\n\032\032frame-address\r= \n$hex\r\n\032\032frame-address-end\r\n in \r\n\032\032frame-function-name\= r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n = at \r\n\032\032frame-source-file\r\n${escapedsrcfile}\r\n\032\032frame-sour= ce-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source= -end\r\n\r\n\r\n\032\032frame-end\r\n(\r\n\032\032frame-begin .*\r\n\r\n\03= 2\032frame-end\r\n)*$gdb_prompt$" \ { pass "backtrace from shlibrary" } + -re "\r\n\032\032post-prompt\r\n\r\n\032\032frame-begin 0 $hex\r\n.0= \r\n(\032\032frame-address\r\n$hex\r\n\032\032frame-address-end\r\n in \r= \n)*\032\032frame-function-name\r\n\.?printf\r\n\032\032frame-args\r\n \\(.= *frame-end\r\n\r\n\032\032frame-begin 1 $hex\r\n.1 \r\n\032\032frame-addre= ss\r\n$hex\r\n\032\032frame-address-end\r\n in \r\n\032\032frame-function-n= ame\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\= r\n at \r\n\032\032frame-source-file\r\n${escapedsrcfile}\r\n\032\032frame-= source-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-so= urce-end\r\n\r\n\r\n\032\032frame-end\r\n(\r\n\032\032frame-begin .*\r\n\r\= n\032\032frame-end\r\n)\r\n\032\032error-begin\r\n.*\032\032error\r\n$gdb_p= rompt$" \ + { pass "backtrace from shlibrary" } -re "\r\n\032\032post-prompt\r\n\r\n\032\032frame-begin 0 $hex\r\n.0 = \r\n(\032\032frame-address\r\n$hex\r\n\032\032frame-address-end\r\n in \r\= n)*\032\032frame-function-name\r\nprintf\r\n\032\032frame-args\r\n \\(.*fra= me-end\r\n\r\n\032\032frame-begin 1 $hex\r\n.1 \r\n\032\032frame-address\r= \n$hex\r\n\032\032frame-address-end\r\n in \r\n\032\032frame-function-name\= r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n = at \r\n\032\032frame-source-file\r\n.*${srcfile}\r\n\032\032frame-source-fi= le-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source-end\= r\n\r\n\r\n\032\032frame-end\r\n(\r\n\032\032frame-begin .*\r\n\r\n\032\032= frame-end\r\n)*$gdb_prompt$" \ { setup_xfail "*-*-*" 1270 fail "backtrace from shlibrary" }