From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23805 invoked by alias); 15 Apr 2005 17:20:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23722 invoked from network); 15 Apr 2005 17:20:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 15 Apr 2005 17:20:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j3FHK1pj029755 for ; Fri, 15 Apr 2005 13:20:01 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j3FHK1O15474 for ; Fri, 15 Apr 2005 13:20:01 -0400 Received: from localhost.localdomain (vpn50-9.rdu.redhat.com [172.16.50.9]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j3FHK0js007393 for ; Fri, 15 Apr 2005 13:20:01 -0400 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id j3FHJtBV011372 for ; Fri, 15 Apr 2005 10:19:55 -0700 Date: Fri, 15 Apr 2005 17:20:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [RFC] Eliminate deprecated_show_value_hack from remote.c Message-ID: <20050415101955.7bf2bf94@ironwood.lan> In-Reply-To: <20050415092223.007a21bf@ironwood.lan> References: <20050406135537.0ebe7edc@ironwood.lan> <20050406205942.GA22779@nevyn.them.org> <20050406144004.28b4a437@ironwood.lan> <20050414193757.GD19792@nevyn.them.org> <20050415092223.007a21bf@ironwood.lan> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-04/txt/msg00159.txt.bz2 On Fri, 15 Apr 2005 09:22:23 -0700 Kevin Buettner wrote: > On Thu, 14 Apr 2005 15:37:57 -0400 > Daniel Jacobowitz wrote: > > > On Wed, Apr 06, 2005 at 02:40:04PM -0700, Kevin Buettner wrote: > > > Here's an update to my recently posted patch. The only difference > > > between it and my earlier patch is the addition of the word "packet" > > > to the message printed by show_remote_protocol_packet_cmd(). > > > > > > * remote.c (show_remote_protocol_packet_cmd): New function. > > > (show_remote_protocol_vcont_packet_cmd ) > > > (show_remote_protocol_qSymbol_packet_cmd) > > > (show_remote_protocol_P_packet_cmd) > > > (show_remote_protocol_Z_software_bp_packet_cmd) > > > (show_remote_protocol_Z_hardware_bp_packet_cmd) > > > (show_remote_protocol_Z_write_wp_packet_cmd) > > > (show_remote_protocol_Z_read_wp_packet_cmd) > > > (show_remote_protocol_Z_access_wp_packet_cmd) > > > (show_remote_protocol_binary_download_cmd) > > > (show_remote_protocol_qPart_auxv_packet_cmd) > > > (show_remote_protocol_p_packet_cmd ): Replace calls to > > > deprecated_show_value_hack() and show_packet_config_cmd() > > > with single call to show_remote_protocol_packet_cmd(). > > > > Do you want to go ahead with this patch, or just remove the double > > printing as discussed on gdb@? > > The latter. I'll prepare a new patch today. Done. The patch which removes the printing of redundant information may be found here: http://sources.redhat.com/ml/gdb-patches/2005-04/msg00158.html Since the new patch also eliminates the calls to deprecated_show_value_hack(), the patches found in this thread (the one I'm replying to) should be considered withdrawn. Kevin