From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16460 invoked by alias); 15 Apr 2005 08:17:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16106 invoked from network); 15 Apr 2005 08:17:04 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 15 Apr 2005 08:17:04 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j3F8H4bj013187 for ; Fri, 15 Apr 2005 04:17:04 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j3F8H3O03624 for ; Fri, 15 Apr 2005 04:17:03 -0400 Received: from cygbert.vinschen.de (vpn50-14.rdu.redhat.com [172.16.50.14]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j3F8H1YE005015 for ; Fri, 15 Apr 2005 04:17:02 -0400 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 2DA7657D95; Fri, 15 Apr 2005 10:16:54 +0200 (CEST) Date: Fri, 15 Apr 2005 08:17:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA/sim] Resurrect sh64 target Message-ID: <20050415081654.GB13574@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050330174817.GA26190@cygbert.vinschen.de> <20050414173430.GA26377@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050414173430.GA26377@nevyn.them.org> User-Agent: Mutt/1.4.2i X-SW-Source: 2005-04/txt/msg00155.txt.bz2 On Apr 14 13:34, Daniel Jacobowitz wrote: > On Wed, Mar 30, 2005 at 07:48:17PM +0200, Corinna Vinschen wrote: > > * configure.ac: Add explicit sh64 case. > > * configure: Regenerate. > > * sh64/configure.ac: New file. > > * sh64/configure.in: Remove. > > * sh64/configure: Regenerate. > > * sh64/defs-media.h (sem_fields): Add missing sfmt_ldhil member. > > * sh64/sim-if.c (sim_open): Use struct bfd instead of struct _bfd. > > (sim_create_inferior): Ditto. > > Hi Corinna, > > This patch is fine. Please fix the space/tab mismatch in > sim/configure.ac before committing: > > > - sh*-*-*) > > + sh64-*-*) > > + AC_CONFIG_SUBDIRS(sh64) > > + testsuite=yes > > + common=yes > > + ;; > > + sh-*-*) I just had a look into this and it turns out that *all* AC_CONFIG_SUBDIRS lines in the configure.ac file are prefixed with only spaces, while the other lines (testsuite/common) are prefixed with a tab and 3 spaces. For now, I decided to keep it as it is and check it in. I don't know if it makes sense to change this globally in the file, but if so, just drop a note and I will fix it. > Also, please don't send diffs to generated files to the list. I was > putting off reviewing this because I was intimidated by the 359k file > size - which turned out to be entirely sim/sh64/configure :-) I'm terribly sorry. I usually don't send generated files, it was really an oversight. If that happens again, please send a quick note and I'll resend a patch without generated files, no problem. Thanks for reviewing! Applied. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat, Inc.