From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9762 invoked by alias); 14 Apr 2005 19:38:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9402 invoked from network); 14 Apr 2005 19:37:58 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 14 Apr 2005 19:37:58 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DMAA1-0005DH-Qi; Thu, 14 Apr 2005 15:37:57 -0400 Date: Thu, 14 Apr 2005 19:38:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Eliminate deprecated_show_value_hack from remote.c Message-ID: <20050414193757.GD19792@nevyn.them.org> Mail-Followup-To: Kevin Buettner , gdb-patches@sources.redhat.com References: <20050406135537.0ebe7edc@ironwood.lan> <20050406205942.GA22779@nevyn.them.org> <20050406144004.28b4a437@ironwood.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050406144004.28b4a437@ironwood.lan> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00147.txt.bz2 On Wed, Apr 06, 2005 at 02:40:04PM -0700, Kevin Buettner wrote: > Here's an update to my recently posted patch. The only difference > between it and my earlier patch is the addition of the word "packet" > to the message printed by show_remote_protocol_packet_cmd(). > > * remote.c (show_remote_protocol_packet_cmd): New function. > (show_remote_protocol_vcont_packet_cmd ) > (show_remote_protocol_qSymbol_packet_cmd) > (show_remote_protocol_P_packet_cmd) > (show_remote_protocol_Z_software_bp_packet_cmd) > (show_remote_protocol_Z_hardware_bp_packet_cmd) > (show_remote_protocol_Z_write_wp_packet_cmd) > (show_remote_protocol_Z_read_wp_packet_cmd) > (show_remote_protocol_Z_access_wp_packet_cmd) > (show_remote_protocol_binary_download_cmd) > (show_remote_protocol_qPart_auxv_packet_cmd) > (show_remote_protocol_p_packet_cmd ): Replace calls to > deprecated_show_value_hack() and show_packet_config_cmd() > with single call to show_remote_protocol_packet_cmd(). Do you want to go ahead with this patch, or just remove the double printing as discussed on gdb@? -- Daniel Jacobowitz CodeSourcery, LLC