From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27072 invoked by alias); 13 Apr 2005 12:09:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26581 invoked from network); 13 Apr 2005 12:09:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 13 Apr 2005 12:09:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DLgg5-000426-2k; Wed, 13 Apr 2005 08:09:05 -0400 Date: Wed, 13 Apr 2005 12:09:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: Eli Zaretskii , gdb-patches@sources.redhat.com, "Maciej W. Rozycki" Subject: Re: Support for "break *ADDRESS thread THREADNO" Message-ID: <20050413120904.GA15220@nevyn.them.org> Mail-Followup-To: "Maciej W. Rozycki" , Eli Zaretskii , gdb-patches@sources.redhat.com, "Maciej W. Rozycki" References: <20050412181334.GA2560@nevyn.them.org> <01c53f90$Blat.v2.4$17427900@zahav.net.il> <20050412185549.GA9715@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00110.txt.bz2 On Wed, Apr 13, 2005 at 11:35:29AM +0100, Maciej W. Rozycki wrote: > On Tue, 12 Apr 2005, Daniel Jacobowitz wrote: > > > > Why was it done like this? because "*ADDRESS" is interpreted as an > > > expression in the current language, or is there some other reason? > > > > I assume so. It is parsed as an expression, not just an address; for > > instance "break *thread" would actually work if thread is a pointer to > > a function. > > I think the actual problem is the expression parser cannot be told to > stop successfully on an unparseable token as long as the expression > collected so far is valid and let the caller deal with that. AFAICS the > parser can only stop on a string terminator or optionally a comma, > otherwise it issues an error. And - can yacc do that? Are you sure that there's no C expression that's valid with and without a trailing identifier, by the way? I certainly find that believable, but I haven't thought about it too hard. -- Daniel Jacobowitz CodeSourcery, LLC