From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6724 invoked by alias); 12 Apr 2005 19:22:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6675 invoked from network); 12 Apr 2005 19:22:52 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 12 Apr 2005 19:22:52 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DLQyI-0002wl-Mn; Tue, 12 Apr 2005 15:22:50 -0400 Date: Tue, 12 Apr 2005 19:22:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: "Maciej W. Rozycki" , gdb-patches@sources.redhat.com Subject: Re: Support for "break *ADDRESS thread THREADNO" Message-ID: <20050412192250.GA11300@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , "Maciej W. Rozycki" , gdb-patches@sources.redhat.com References: <20050412181334.GA2560@nevyn.them.org> <01c53f90$Blat.v2.4$17427900@zahav.net.il> <20050412185549.GA9715@nevyn.them.org> <01c53f92$Blat.v2.4$280330c0@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c53f92$Blat.v2.4$280330c0@zahav.net.il> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00105.txt.bz2 On Tue, Apr 12, 2005 at 10:01:19PM +0300, Eli Zaretskii wrote: > > Date: Tue, 12 Apr 2005 14:55:49 -0400 > > From: Daniel Jacobowitz > > Cc: "Maciej W. Rozycki" , gdb-patches@sources.redhat.com > > > > There's already common code for this, that's where most of the 'thread > > THREADNO' support is. I think it's in linespec.c somewhere, but it > > might be in breakpoint.c. > > Doing this in one of these two place would be okay, since they are > language independent. > > > TBH, the mechanism is fragile; I can't think of a more robust way but > > there must be one. > > How about a convenience variable $thread that will hold the current > thread ID? Then we could simply use a condition "if $thread == TID". > > Or maybe a command option "break --thread=ID *ADDR". (Or did we > decide to not use such syntax?) Whatever we do, if we change anything, let's use something separate from the existing argument to break. The MI can represent this explicitly, and ought to. It's just a CLI problem. -- Daniel Jacobowitz CodeSourcery, LLC