Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jonathan Larmour <jifl@eCosCentric.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: SH simulator build fix
Date: Tue, 12 Apr 2005 19:10:00 -0000	[thread overview]
Message-ID: <20050412191039.GA10613@nevyn.them.org> (raw)
In-Reply-To: <425C1BD6.6020105@eCosCentric.com>

On Tue, Apr 12, 2005 at 08:04:54PM +0100, Jonathan Larmour wrote:
> The SH simulator doesn't build on slightly older GCC. gencode.c relies on 
> the C99 ability (like C++) to define variables after code in a function. 
> So for example it would generate source code in code.c like:
> 
>   case 37:
>     {
>       {
>         RAISE_EXCEPTION_IF_IN_DELAY_SLOT ();
>         int i;
> 
> where RAISE_EXCEPTION_IF_IN_DELAY_SLOT is:
> #define RAISE_EXCEPTION_IF_IN_DELAY_SLOT() \
>   if (in_delay_slot) RAISE_EXCEPTION (SIGILL)
> 
> 
> Fortunately the fix is trivial, and attached!
> 
> 2005-04-12  Jonathan Larmour  <jifl@eCosCentric.com>
> 
> 	* gencode.c (tab): Avoid inserting code before variables all 
> 	declared.
> 
> I have CVS write access to src, so I can do the check-in assuming that's 
> easier.

Sure looks like an obvious fix to me; please go ahead, assuming that
you have tested the resulting simulator.


-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-04-12 19:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12 19:05 Jonathan Larmour
2005-04-12 19:10 ` Daniel Jacobowitz [this message]
2005-04-12 21:50   ` Jonathan Larmour
2005-04-14 19:13     ` Daniel Jacobowitz
2005-04-14 20:16       ` Jonathan Larmour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050412191039.GA10613@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jifl@eCosCentric.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox