From: Paul Gilliam <pgilliam@us.ibm.com>
To: gdb-patches@sources.redhat.com
Subject: [patch] In testsuite, make 'test_compiler_info' work like 'istarget'
Date: Wed, 06 Apr 2005 21:11:00 -0000 [thread overview]
Message-ID: <200504061408.50092.pgilliam@us.ibm.com> (raw)
The dejagnu procedure 'test_compiler_info' works in much the same way as the dejagnu procedure
''istarget': it takes a pattern as argument and tests that pattern against a magic string. Unlike
'istarget', 'test_compiler_info' does not return the magic string if the argument is null. This patch
fixes that.
With this patch, you can do this:
switch -glob [test_compiler_info] {
"gcc-1-*" { set gcc_compiled 1 }
"gcc-2-*" { set gcc_compiled 2 }
"gcc-3-*" { set gcc_compiled 3 }
"gcc-4-*" { set gcc_compiled 4 }
"gcc-5-*" { set gcc_compiled 5 }
"hpcc-*" { set hp_cc_compiler 1 }
"hpacc-*" { set hp_aCC_compiler 1 }
default { warning "unknown compiler" }
}
instead of this:
if {[test_compiler_info "gcc-1-*"]} then { set gcc_compiled 1
} elseif {[test_compiler_info "gcc-2-*"]} then { set gcc_compiled 2
} elseif {[test_compiler_info "gcc-3-*"]} then { set gcc_compiled 3
} elseif {[test_compiler_info "gcc-4-*"]} then { set gcc_compiled 4
} elseif {[test_compiler_info "gcc-5-*" ]} then { set gcc_compiled 5
} elseif {[test_compiler_info "hpcc-*" ]} then { set hp_cc_compiler 1
} elseif {[test_compiler_info "hpacc-*"]} then { set hp_aCC_compiler 1
} else { warning "unknown compiler" }
Of course you could do the following, but that would be cheating, right?
global compiler_info
switch -glob $compiler_info {
"gcc-1-*" { set gcc_compiled 1 }
"gcc-2-*" { set gcc_compiled 2 }
"gcc-3-*" { set gcc_compiled 3 }
"gcc-4-*" { set gcc_compiled 4 }
"gcc-5-*" { set gcc_compiled 5 }
"hpcc-*" { set hp_cc_compiler 1 }
"hpacc-*" { set hp_aCC_compiler 1 }
default { warning "unknown compiler" }
}
OK to commit?
-=# Paul #=-
--
2005-04-06 Paul Gilliam <pgilliam@us.ibm.com>
* testsuite/lib/gdb.exp: Make 'test_compiler_info' work like
'istarget' - return compiler_info if null argument.
Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.58
diff -c -3 -p -r1.58 gdb.exp
*** lib/gdb.exp 10 Sep 2004 01:04:59 -0000 1.58
--- lib/gdb.exp 6 Apr 2005 20:38:35 -0000
*************** proc get_compiler_info {binfile args} {
*** 1293,1298 ****
--- 1293,1309 ----
proc test_compiler_info { compiler } {
global compiler_info
+
+ # if no arg, return the compiler_info string
+
+ if [string match "" $compiler] {
+ if [info exists compiler_info] {
+ return $compiler_info
+ } else {
+ perror "No compiler info found."
+ }
+ }
+
return [string match $compiler $compiler_info]
}
next reply other threads:[~2005-04-06 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-06 21:11 Paul Gilliam [this message]
2005-04-06 21:14 ` Daniel Jacobowitz
2005-04-06 21:41 ` [commit] " Paul Gilliam
2005-04-06 21:43 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504061408.50092.pgilliam@us.ibm.com \
--to=pgilliam@us.ibm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox