From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7612 invoked by alias); 1 Apr 2005 01:51:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6384 invoked from network); 1 Apr 2005 01:50:59 -0000 Received: from unknown (HELO lakermmtao07.cox.net) (68.230.240.32) by sourceware.org with SMTP; 1 Apr 2005 01:50:59 -0000 Received: from white ([68.9.64.121]) by lakermmtao07.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050401015059.KNSF19214.lakermmtao07.cox.net@white>; Thu, 31 Mar 2005 20:50:59 -0500 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1DHCEA-0000ZI-00; Thu, 31 Mar 2005 21:49:42 -0500 Date: Fri, 01 Apr 2005 01:51:00 -0000 From: Bob Rossi To: Nick Roberts Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [PATCH: gdb/mi + doco] -var-update Message-ID: <20050401024942.GA2179@white> Mail-Followup-To: Nick Roberts , Andrew Cagney , gdb-patches@sources.redhat.com References: <16919.7660.144228.334687@farnswood.snap.net.nz> <01c5167f$Blat.v2.4$9a7a6f60@zahav.net.il> <16919.53411.753668.336933@farnswood.snap.net.nz> <01c51709$Blat.v2.4$4a3292a0@zahav.net.il> <16921.18627.457594.938060@farnswood.snap.net.nz> <01c517d0$Blat.v2.4$09a26040@zahav.net.il> <16922.43915.346792.973282@farnswood.snap.net.nz> <01c51898$Blat.v2.4$f6fd05c0@zahav.net.il> <16929.8147.933720.246602@farnswood.snap.net.nz> <16955.41017.161288.832646@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16955.41017.161288.832646@farnswood.snap.net.nz> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-04/txt/msg00004.txt.bz2 On Sat, Mar 19, 2005 at 04:44:57PM +1300, Nick Roberts wrote: > > I would like to commit this (source code) patch from last month. I accidently > reverted some of changes last time I presented it so I attach it here in its > proper form. > > As Andrew doesn't appear to around is there any chance a global maintainer > can look at it? Its pretty lightweight. Hi Nick, I have some spare time waiting for my patches to get reviewed, so I figure'd I'd look at yours. If you care, I have just a few comments. Bob Rossi > *** /home/nick/src/gdb/mi/mi-cmd-var.c.~1.21.~ 2005-02-13 00:36:20.000000000 +1300 > --- /home/nick/src/gdb/mi/mi-cmd-var.c 2005-03-01 14:03:45.000000000 +1300 > *************** > *** 30,38 **** > #include > #include "gdb_string.h" > > extern int varobjdebug; /* defined in varobj.c */ > > ! static int varobj_update_one (struct varobj *var); > > /* VAROBJ operations */ > > --- 30,44 ---- > #include > #include "gdb_string.h" > > + const char novalues[] = "\"--no-values\""; > + const char withvalues[] = "\"--with-values\""; > + const char simplevalues[] = "\"--simple-values\""; > + const char allvalues[] = "\"--all-values\""; These could be made static. > extern int varobjdebug; /* defined in varobj.c */ > > ! static int varobj_update_one (struct varobj *var, > ! enum print_values print_values); > > /* VAROBJ operations */ > > *************** > *** 262,284 **** > error (_("mi_cmd_var_list_children: Usage: [PRINT_VALUES] NAME")); > > /* Get varobj handle, if a valid var obj name was specified */ > ! if (argc == 1) var = varobj_get_handle (argv[0]); > ! else var = varobj_get_handle (argv[1]); > if (var == NULL) > error (_("Variable object not found")); > > numchild = varobj_list_children (var, &childlist); > ui_out_field_int (uiout, "numchild", numchild); > if (argc == 2) > ! if (strcmp (argv[0], "0") == 0 > ! || strcmp (argv[0], "--no-values") == 0) > ! print_values = PRINT_NO_VALUES; > ! else if (strcmp (argv[0], "1") == 0 > ! || strcmp (argv[0], "--all-values") == 0) > ! print_values = PRINT_ALL_VALUES; > ! else > ! error (_("Unknown value for PRINT_VALUES: must be: 0 or \"--no-values\", 1 or \"--all-values\"")); > ! else print_values = PRINT_NO_VALUES; > > if (numchild <= 0) > return MI_CMD_DONE; > --- 268,296 ---- > error (_("mi_cmd_var_list_children: Usage: [PRINT_VALUES] NAME")); > > /* Get varobj handle, if a valid var obj name was specified */ > ! if (argc == 1) > ! var = varobj_get_handle (argv[0]); > ! else > ! var = varobj_get_handle (argv[1]); > if (var == NULL) > error (_("Variable object not found")); > > numchild = varobj_list_children (var, &childlist); > ui_out_field_int (uiout, "numchild", numchild); > if (argc == 2) > ! { > ! if (strcmp (argv[0], "0") == 0 > ! || strcmp (argv[0], "--no-values") == 0) > ! print_values = PRINT_NO_VALUES; > ! else if (strcmp (argv[0], "1") == 0 > ! || strcmp (argv[0], "--with-values") == 0) instead of using "--no-values" and "--with-values" you could use the variable "novalues" and "withvalues". > ! print_values = PRINT_ALL_VALUES; > ! else > ! error (_("Unknown value for PRINT_VALUES: must be: 0 or %s, 1 or %s"), > ! novalues, withvalues); > ! } > ! else > ! print_values = PRINT_NO_VALUES; > > if (numchild <= 0) > return MI_CMD_DONE; > *************** > *** 426,436 **** > struct cleanup *cleanup; > char *name; > int nv; > > ! if (argc != 1) > ! error (_("mi_cmd_var_update: Usage: NAME.")); > > ! name = argv[0]; > > /* Check if the parameter is a "*" which means that we want > to update all variables */ > --- 438,467 ---- > struct cleanup *cleanup; > char *name; > int nv; > + enum print_values print_values; > > ! if (argc != 1 && argc != 2) > ! error (_("mi_cmd_var_update: Usage: [PRINT_VALUES] NAME.")); > > ! if (argc == 1) > ! name = argv[0]; > ! else > ! name = (argv[1]); > ! > ! if (argc == 2) > ! { > ! if (strcmp (argv[0], "0") == 0 > ! || strcmp (argv[0], "--no-values") == 0) > ! print_values = PRINT_NO_VALUES; > ! else if (strcmp (argv[0], "1") == 0 > ! || strcmp (argv[0], "--with-values") == 0) same as above with the --no-values and --with-values > ! print_values = PRINT_ALL_VALUES; > ! else > ! error (_("Unknown value for PRINT_VALUES: must be: 0 or %s, 1 or %s"), > ! novalues, withvalues); > ! } > ! else > ! print_values = PRINT_NO_VALUES; > > /* Check if the parameter is a "*" which means that we want > to update all variables */