From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23976 invoked by alias); 30 Mar 2005 23:01:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23822 invoked from network); 30 Mar 2005 23:01:01 -0000 Received: from unknown (HELO e34.co.us.ibm.com) (32.97.110.132) by sourceware.org with SMTP; 30 Mar 2005 23:01:01 -0000 Received: from westrelay03.boulder.ibm.com (westrelay03.boulder.ibm.com [9.17.195.12]) by e34.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j2UN105b430632 for ; Wed, 30 Mar 2005 18:01:01 -0500 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by westrelay03.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j2UN1072149912 for ; Wed, 30 Mar 2005 16:01:00 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j2UN10cR018302 for ; Wed, 30 Mar 2005 16:01:00 -0700 Received: from dyn9047022123.beaverton.ibm.com (dyn9047022123.beaverton.ibm.com [9.47.22.123]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j2UN0xtP018262; Wed, 30 Mar 2005 16:01:00 -0700 From: Paul Gilliam Reply-To: pgilliam@us.ibm.com To: Daniel Jacobowitz Subject: Re: [patch] Allow altivec-{abi,regs}.c to be compiled by IBM's xlc compiler Date: Wed, 30 Mar 2005 23:01:00 -0000 User-Agent: KMail/1.6.2 Cc: gdb-patches@sources.redhat.com References: <200503091251.58836.pgilliam@us.ibm.com> <20050329204333.GB20646@nevyn.them.org> In-Reply-To: <20050329204333.GB20646@nevyn.them.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200503301456.56428.pgilliam@us.ibm.com> X-SW-Source: 2005-03/txt/msg00394.txt.bz2 On Tuesday 29 March 2005 12:43, Daniel Jacobowitz wrote > Warning takes a string. TCL doesn't use semicolons. OK, I've fixed those two things (I don't know how I missed the type of argument to 'warning') and have included the revised patch below. -=# Paul #=- PS: semicolons ARE used in TCL - as statement separators. Of course in this case they are redundent, being followed by a new-line, the other statement separator 8-) 2005-03-09 Paul Gilliam * gdb.arch/altivec-abi.exp: Check for compiler and set 'use altivec' flag accordingly. * gdb.arch/altivec-regs.exp: Likewise. Index: gdb.arch/altivec-abi.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/altivec-abi.exp,v retrieving revision 1.3 diff -c -3 -p -r1.3 altivec-abi.exp *** gdb.arch/altivec-abi.exp 20 Jan 2003 15:40:07 -0000 1.3 --- gdb.arch/altivec-abi.exp 9 Mar 2005 19:25:34 -0000 *************** set testfile "altivec-abi" *** 41,47 **** set binfile ${objdir}/${subdir}/${testfile} set srcfile ${testfile}.c ! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable {debug additional_flags=-w}] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } --- 41,62 ---- set binfile ${objdir}/${subdir}/${testfile} set srcfile ${testfile}.c ! set compile_flags {debug additional_flags=-w} ! if [get_compiler_info $binfile] { ! warning "get_compiler failed" ! return -1 ! } ! ! if [test_compiler_info gcc*] { ! set compile_flags "$compile_flags additional_flags=-maltivec" ! } elseif [test_compiler_info xlc*] { ! set compile_flags "$compile_flags additional_flags=-qaltivec" ! } else { ! warning "unknown compiler" ! return -1 ! } ! ! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable $compile_flags] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } Index: gdb.arch/altivec-regs.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/altivec-regs.exp,v retrieving revision 1.2 diff -c -3 -p -r1.2 altivec-regs.exp *** gdb.arch/altivec-regs.exp 20 Jan 2003 15:40:07 -0000 1.2 --- gdb.arch/altivec-regs.exp 9 Mar 2005 19:25:34 -0000 *************** set testfile "altivec-regs" *** 41,47 **** set binfile ${objdir}/${subdir}/${testfile} set srcfile ${testfile}.c ! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable {debug additional_flags=-w}] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } --- 41,62 ---- set binfile ${objdir}/${subdir}/${testfile} set srcfile ${testfile}.c ! set compile_flags {debug additional_flags=-w} ! if [get_compiler_info $binfile] { ! warning "get_compiler failed" ! return -1 ! } ! ! if [test_compiler_info gcc*] { ! set compile_flags "$compile_flags additional_flags=-maltivec" ! } elseif [test_compiler_info xlc*] { ! set compile_flags "$compile_flags additional_flags=-qaltivec" ! } else { ! warning "unknown compiler" ! return -1 ! } ! ! if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable $compile_flags] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." }