From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10701 invoked by alias); 26 Mar 2005 08:02:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10616 invoked from network); 26 Mar 2005 08:02:34 -0000 Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 26 Mar 2005 08:02:34 -0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j2Q82S9A019324; Sat, 26 Mar 2005 09:02:28 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.3/8.13.3) with ESMTP id j2Q82SNB032609; Sat, 26 Mar 2005 09:02:28 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.3/8.13.3/Submit) id j2Q82QHU011664; Sat, 26 Mar 2005 09:02:26 +0100 (CET) Date: Sat, 26 Mar 2005 08:02:00 -0000 Message-Id: <200503260802.j2Q82QHU011664@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: gdb-patches@sources.redhat.com In-reply-to: <20050326004308.GH2545@adacore.com> (message from Joel Brobecker on Fri, 25 Mar 2005 16:43:08 -0800) Subject: Re: [RFA] Fix problem fetching/setting FSR register (IRIX) References: <20050326004308.GH2545@adacore.com> X-SW-Source: 2005-03/txt/msg00333.txt.bz2 Date: Fri, 25 Mar 2005 16:43:08 -0800 From: Joel Brobecker Hello, The attached patch fixes the problem reported at: http://sources.redhat.com/ml/gdb-patches/2005-03/msg00294.html The explaination of the actual problem is detailed at: http://sources.redhat.com/ml/gdb-patches/2005-03/msg00309.html I have also added some comments in the code, and included Mark's comments. 2005-03-25 Joel Brobecker * irix5-nat.c (supply_fpregset): Fix bug that caused the FSR register value to be incorrectly written in the regcache. (fill_fpregset): Fix bug that caused the FSR register value to be incorrectly read from the regcache. Fixes [E223-028]. Tested on mips-irix. No regression. OK to apply? Oh, my message was sort of intended as approval. But now that you asked again, there's one little nit: what's that funny E223-028. If it is what I think it is, then I'm not sure if we should add bug ID's from a non-public bug database to our ChangeLog. (I will submit a testcase for this asap) A somewhat general MIPS floating-point test would be great ;-). Mark