Re: PATCH: Windows sockets

[Christopher Faylor <me@cgf.cx>]

On Fri, Mar 25, 2005 at 05:27:05PM -0800, Mark Mitchell wrote:
>Here's the first "interesting" patch for Windows support.  This patch
>modifies ser-tcp.c to support Windows, so that we can use a GDB
>running on Windows to talk to a gdbserver process.  
>
>Here is a sumary of the changes in this patch:
>
>1. Link with -lws2_32 on MinGW so we can use sockets.
>
>2. In defs.h, define WINAPI so that source files know whether they are
>   supposed to use the Windows API.
>
>3. Move ser_unix_readchar and friends (which were only barely
>   UNIX-specific) into ser-base.c, renaming appropriately.
>
>4. Add a new member (read_prim) to struct serial_ops, and use it from
>   ser_base_readchar.  The reason for this is that sockets must be
>   read with "recv" on Windows; plain "read" does not work.  So, we
>   need a way to indicate which low-level primitive to use to read
>   from a file descriptor.
>
>5. Make a handful of minor changes to ter-tcp.c to account for
>   differences in the BSD and Windows sockets APIs.
>
>6. Tweak safe_strerror to deal with Windows sockets error codes.
>
>Tested on x86_64-unknown-linux-gnu, to make sure I didn't break UNIX,
>and cursorily on Windows (with other patches, not yet submitted).
>
>OK to apply?

The windows-specific configury parts look ok to me.  That's all I
can approve, although the other bits look right too.

cgf