From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: [rfa] Add new breakpoints for arm-linux Thumb
Date: Fri, 25 Mar 2005 21:21:00 -0000 [thread overview]
Message-ID: <20050325212135.GA3424@nevyn.them.org> (raw)
Just like for ARM mode, Linux uses different instructions for Thumb
breakpoints than other ARM targets. These properly raise a SIGTRAP
rather than some other signal, which makes GDB much happier.
Committed to csl-arm-20050325-branch. OK for HEAD?
--
Daniel Jacobowitz
CodeSourcery, LLC
2005-03-25 Daniel Jacobowitz <dan@codesourcery.com>
* arm-linux-tdep.c (arm_linux_thumb_be_breakpoint)
(arm_linux_thumb_le_breakpoint): New. Update comments.
(arm_linux_init_abi): Set Thumb breakpoints also.
Index: gdb/gdb/arm-linux-tdep.c
===================================================================
--- gdb.orig/gdb/arm-linux-tdep.c 2005-03-24 11:47:34.557904020 -0500
+++ gdb/gdb/arm-linux-tdep.c 2005-03-24 11:54:16.014184011 -0500
@@ -39,13 +39,16 @@
is to execute a particular software interrupt, rather than use a
particular undefined instruction to provoke a trap. Upon exection
of the software interrupt the kernel stops the inferior with a
- SIGTRAP, and wakes the debugger. Since ARM GNU/Linux doesn't support
- Thumb at the moment we only override the ARM breakpoints. */
+ SIGTRAP, and wakes the debugger. */
static const char arm_linux_arm_le_breakpoint[] = { 0x01, 0x00, 0x9f, 0xef };
static const char arm_linux_arm_be_breakpoint[] = { 0xef, 0x9f, 0x00, 0x01 };
+static const char arm_linux_thumb_be_breakpoint[] = {0xde, 0x01};
+
+static const char arm_linux_thumb_le_breakpoint[] = {0x01, 0xde};
+
/* Description of the longjmp buffer. */
#define ARM_LINUX_JB_ELEMENT_SIZE INT_REGISTER_SIZE
#define ARM_LINUX_JB_PC 21
@@ -466,10 +469,17 @@ arm_linux_init_abi (struct gdbarch_info
tdep->lowest_pc = 0x8000;
if (info.byte_order == BFD_ENDIAN_BIG)
- tdep->arm_breakpoint = arm_linux_arm_be_breakpoint;
+ {
+ tdep->arm_breakpoint = arm_linux_arm_be_breakpoint;
+ tdep->thumb_breakpoint = arm_linux_thumb_be_breakpoint;
+ }
else
- tdep->arm_breakpoint = arm_linux_arm_le_breakpoint;
+ {
+ tdep->arm_breakpoint = arm_linux_arm_le_breakpoint;
+ tdep->thumb_breakpoint = arm_linux_thumb_le_breakpoint;
+ }
tdep->arm_breakpoint_size = sizeof (arm_linux_arm_le_breakpoint);
+ tdep->thumb_breakpoint_size = sizeof (arm_linux_thumb_le_breakpoint);
tdep->fp_model = ARM_FLOAT_FPA;
next reply other threads:[~2005-03-25 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 21:21 Daniel Jacobowitz [this message]
2005-03-29 15:47 ` Richard Earnshaw
2005-03-29 16:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050325212135.GA3424@nevyn.them.org \
--to=drow@false.org \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox