From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 303 invoked by alias); 24 Mar 2005 22:51:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32748 invoked from network); 24 Mar 2005 22:51:12 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 24 Mar 2005 22:51:12 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j2OMpCeb020624 for ; Thu, 24 Mar 2005 17:51:12 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j2OMpCO32261; Thu, 24 Mar 2005 17:51:12 -0500 Received: from localhost.localdomain (vpn50-40.rdu.redhat.com [172.16.50.40]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j2OMpBmq022137; Thu, 24 Mar 2005 17:51:11 -0500 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id j2OMp5j8030819; Thu, 24 Mar 2005 15:51:06 -0700 Date: Thu, 24 Mar 2005 22:51:00 -0000 From: Kevin Buettner To: Ulrich Weigand Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Move TLS load module addr fetching to dwarf2loc.c Message-ID: <20050324155105.3eec0b42@ironwood.lan> In-Reply-To: <200503242227.j2OMRptl027698@53v30g15.boeblingen.de.ibm.com> References: <20050324124530.7714cb1c@ironwood.lan> <200503242227.j2OMRptl027698@53v30g15.boeblingen.de.ibm.com> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00308.txt.bz2 On Thu, 24 Mar 2005 23:27:50 +0100 (CET) Ulrich Weigand wrote: > > * alpha-linux-tdep.c (solib-svr4.h): Include. > > (alpha_linux_init_abi): Register TLS load module fetcher. > > * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise. > > * hppa-linux-tdep.c (hppa_linux_init_abi): Likewise. > > * i386-linux-tdep.c (i386_linux_init_abi): Likewise. > > * ia64-linux-tdep.c (solib-svr4.h): Include. > > (ia64_linux_init_abi): Register TLS load module fetcher. > > * m32r-linux-tdep.c (m32r_linux_init_abi): Likewise. > > * m68klinux-tdep.c (m68k_linux_init_abi): Likewise. > > * mips-linux-tdep.c (mips_linux_init_abi): Likewise. > > * sparc-linux-tdep.c (sparc32_linux_init_abi): Likewise. > > * sparc64-linux-tdep.c (solib-svr4.h): Include. > > (sparc64_linux_init_abi): Register TLS load module fetcher. > > * Makefile.in (alpha-linux-tdep.o, ia64-linux-tdep.o) > > (sparc-linux-tdep.o): Update dependencies. > > What about s390? I guess we need the same change ... I apologize for missing the s390. (I did my search on *linux-tdep.c.) How does the patch below look to you? I've added this to my sandbox and, if it looks okay to you, I'll check it in when the rest of the changes go in. * s390-tdep.c (s390_gdbarch_init): Register TLS load module fetcher. Index: s390-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/s390-tdep.c,v retrieving revision 1.142 diff -u -p -r1.142 s390-tdep.c --- s390-tdep.c 17 Mar 2005 17:44:14 -0000 1.142 +++ s390-tdep.c 24 Mar 2005 22:45:57 -0000 @@ -3007,6 +3007,10 @@ s390_gdbarch_init (struct gdbarch_info i set_gdbarch_print_insn (gdbarch, print_insn_s390); + /* Enable TLS support. */ + set_gdbarch_fetch_tls_load_module_address (gdbarch, + svr4_fetch_objfile_link_map); + return gdbarch; }