From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22571 invoked by alias); 16 Mar 2005 03:16:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22477 invoked from network); 16 Mar 2005 03:16:13 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 16 Mar 2005 03:16:13 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1DBP0z-0007nZ-5Z; Tue, 15 Mar 2005 22:16:09 -0500 Date: Wed, 16 Mar 2005 03:16:00 -0000 From: Daniel Jacobowitz To: "Amit S. Kale" Cc: GDB patches Subject: Re: [patch] gdbserver fails on 32-bit ppc rfs running in a-64 bit 2.6 linux kernel Message-ID: <20050316031609.GA29869@nevyn.them.org> Mail-Followup-To: "Amit S. Kale" , GDB patches References: <200503142137.35799.amitkale@linsyssoft.com> <20050314162252.GA23939@nevyn.them.org> <200503151836.22542.amitkale@linsyssoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503151836.22542.amitkale@linsyssoft.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00209.txt.bz2 On Tue, Mar 15, 2005 at 06:36:22PM +0530, Amit S. Kale wrote: > The strtoul change in my patch was already present. Sorry about that. > > You have changed the data type of thread_resume::thread as well as cont_thread > to unsigned long. "cont_thread = -1" and "(cont_thread > 0)" are still in > place. How does this work? Hmm, looks like you found a real problem here; would you like to fix it? Modern GDBs don't heavily use this code, because of the vCont packet. Otherwise I'll fix it, but I may not find time for a bit. > Can we use a thread value of "0" to indicate all threads or no-thread instead > of "-1"? The condition "cont_thread > 0" becomes valid if we do that. This value can be set from the remote protocol, so we would have to transform it in Hc/Hg support also. -- Daniel Jacobowitz CodeSourcery, LLC