From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8942 invoked by alias); 14 Mar 2005 15:06:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8844 invoked from network); 14 Mar 2005 15:05:56 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 14 Mar 2005 15:05:56 -0000 Received: (qmail 18908 invoked from network); 14 Mar 2005 15:05:55 -0000 Received: from localhost (HELO wren.home) (paul@127.0.0.1) by mail.codesourcery.com with SMTP; 14 Mar 2005 15:05:55 -0000 From: Paul Brook Organization: CodeSourcery To: Daniel Jacobowitz Subject: Re: [patch] Stray "," in mi-support.exp Date: Mon, 14 Mar 2005 15:06:00 -0000 User-Agent: KMail/1.7.2 Cc: gdb-patches@sources.redhat.com References: <200503120127.23761.paul@codesourcery.com> <20050313045243.GA32373@nevyn.them.org> In-Reply-To: <20050313045243.GA32373@nevyn.them.org> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_RhaNCzI4rliM5Df" Message-Id: <200503141505.53659.paul@codesourcery.com> X-SW-Source: 2005-03/txt/msg00200.txt.bz2 --Boundary-00=_RhaNCzI4rliM5Df Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 717 On Sunday 13 March 2005 04:52, Daniel Jacobowitz wrote: > Hmm, it looks right to me, but I'd like for one of the MI maintainers > to comment. With gdbserver, we use -target-select, which produces: > > 47-target-select remote localhost:2346 > Remote debugging from host 127.0.0.1 > 47^connected,thread-id="0",frame={addr="0xb7feac20",func="??",args=[]} > (gdb) > > This is preferable to using the CLI passthrough; want to give that a > shot, and then we can just delete the questionable pattern? That does seem a better solution, and works as expected. Updated patch attached. Ok? Paul 2005-03-14 Paul Brook * lib/mi-support.exp: Use mi_gdb_target_cmd to connect to remote targets. --Boundary-00=_RhaNCzI4rliM5Df Content-Type: text/x-diff; charset="iso-8859-1"; name="patch.gdb_mi_exp" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch.gdb_mi_exp" Content-length: 897 Index: gdb/testsuite/lib/mi-support.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v retrieving revision 1.24 diff -u -p -r1.24 mi-support.exp --- gdb/testsuite/lib/mi-support.exp 18 Jan 2004 15:23:30 -0000 1.24 +++ gdb/testsuite/lib/mi-support.exp 14 Mar 2005 14:50:31 -0000 @@ -494,14 +494,9 @@ proc mi_gdb_load { arg } { } } elseif { [target_info gdb_protocol] == "remote" } { # remote targets - send_gdb "target [target_info gdb_protocol] [target_info netport]\n" - gdb_expect 60 { - -re "\\^done,.*$mi_gdb_prompt$" { - } - timeout { - perror "Unable to connect to remote target" - return -1 - } + if { [mi_gdb_target_cmd "remote" [target_info netport]] != 0 } { + perror "Unable to connect to remote target" + return -1 } send_gdb "48-target-download\n" gdb_expect 10 { --Boundary-00=_RhaNCzI4rliM5Df--