From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17121 invoked by alias); 13 Mar 2005 04:52:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17072 invoked from network); 13 Mar 2005 04:52:48 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 13 Mar 2005 04:52:48 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1DAL5n-0008Su-Gu; Sat, 12 Mar 2005 23:52:43 -0500 Date: Sun, 13 Mar 2005 04:52:00 -0000 From: Daniel Jacobowitz To: Paul Brook Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Stray "," in mi-support.exp Message-ID: <20050313045243.GA32373@nevyn.them.org> Mail-Followup-To: Paul Brook , gdb-patches@sources.redhat.com References: <200503120127.23761.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503120127.23761.paul@codesourcery.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00191.txt.bz2 On Sat, Mar 12, 2005 at 01:27:23AM +0000, Paul Brook wrote: > The attached patch removes what appears to be a stray "," in > testsuite/lib/mi-support.exp > > I'd commit as obvious, but I never can be sure with dejagnu.The relevant > excerpt from testsuite/gdb.log is: > > (gdb) ^M > target remote tcp:localhost:2345^M > &"target remote tcp:localhost:2345\n"^M > ~"Remote debugging using tcp:localhost:2345\n"^M > ~"0x00000000 in ?? ()\n"^M > ^done^M > (gdb) ^M > > Ok? Hmm, it looks right to me, but I'd like for one of the MI maintainers to comment. With gdbserver, we use -target-select, which produces: 47-target-select remote localhost:2346 Remote debugging from host 127.0.0.1 47^connected,thread-id="0",frame={addr="0xb7feac20",func="??",args=[]} (gdb) This is preferable to using the CLI passthrough; want to give that a shot, and then we can just delete the questionable pattern? -- Daniel Jacobowitz CodeSourcery, LLC