Re: PATCH: Introduce gdb_gettimeofday

Mark Kettenis
2005-03-09T10:31:35Z

Date: Tue, 8 Mar 2005 15:29:36 -0800
From: Mark Mitchell <mark@codesourcery.com>

Some systems (Windows) don't have gettimeofday. This patch introduces
a new utility function gdb_gettimeofday; on UNIX systems this is just
a wrapper for gettimeofday, while on other systems it relies on
fallback methods. (In particular, on Windows, we use "time", at least
for now.)

I'm not thrilled. gettimeofday(2) is POSIX, so any decent operating
system should have it. Even cygwin (the only way GDB currently
supports Windows) seems to have it. Is there a coordinated attempt to
make GDB run on Windows in some other way?

If there indeed is such an effort, did you consider adding
gettimeofday(2) to libiberty?

Tested by building on both Windows (with other patches not yet
submitted) and on x86_64-uknown-linux-gnu, and by running the
testsuite on the latter platform with no regressions. I'll check for
copyrights before submission, if this is approved.

OK?

Even if this patch turns out to be the way go, there's a problem:

2005-03-08 Mark Mitchell <mark@codesourcery.com>

* config.in (HAVE_GETTIMEOFDAY): #undef it.

This should not be necessary.

Cheers,

Mark