From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18192 invoked by alias); 7 Mar 2005 19:38:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18142 invoked from network); 7 Mar 2005 19:38:06 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 7 Mar 2005 19:38:06 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D8O3B-0004hP-IP; Mon, 07 Mar 2005 14:37:57 -0500 Date: Mon, 07 Mar 2005 19:38:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [COMMIT] Re: [PATCH] obvious (I think) correction to compiler.c and compiler.cc Message-ID: <20050307193757.GA18042@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200503071039.16604.pgilliam@us.ibm.com> <20050307185048.GA15838@nevyn.them.org> <200503071056.50420.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503071056.50420.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00082.txt.bz2 On Mon, Mar 07, 2005 at 10:56:50AM -0800, Paul Gilliam wrote: > Done. > > Was this obvious and I was too cautious? Dunno. > PS. should I have copied the patch here or is the reference enough? Is fine. Please just reply to the approval without changing the subject, though. > > > On Monday 07 March 2005 10:50, Daniel Jacobowitz wrote: > > On Mon, Mar 07, 2005 at 10:39:16AM -0800, Paul Gilliam wrote: > > > This fixes a problem with this committed patch: > > > > > > http://sources.redhat.com/ml/gdb-patches/2005-03/msg00050.htm > > > > > > 'compiler.c' and 'compiler.cc' where doing the right thing, but > > > get_compiler_info was not evaluating the key line because it did not > > > begin with 'set'. Rather then add another case to get_compiler_info, I > > > changed the the line in compiler.c and compiler.cc to be 'set need_a_set > > > [regsub....]' > > > > > > At first I thought this was obvious, but because it could be fixed in > > > compiler.c and compiler.cc or fixed in get_compiler_info, I thought maybe > > > it wasn't so obvious. I fixed it here in compiler.c and compiler.cc > > > because those are compiler dependent and get_compiler_info is more > > > generic. > > > > > > OK to commit? > > > > OK. > -- Daniel Jacobowitz CodeSourcery, LLC