From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28955 invoked by alias); 3 Mar 2005 17:27:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28330 invoked from network); 3 Mar 2005 17:26:46 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 3 Mar 2005 17:26:46 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D6u5y-0007Lk-9P; Thu, 03 Mar 2005 12:26:42 -0500 Date: Thu, 03 Mar 2005 17:27:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] test for altivec h/w on PowerPC Message-ID: <20050303172642.GB18681@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200503011519.39739.pgilliam@us.ibm.com> <20050302015607.GA1694@nevyn.them.org> <200503021010.17990.pgilliam@us.ibm.com> <200503021346.35253.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503021346.35253.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00031.txt.bz2 On Wed, Mar 02, 2005 at 01:46:35PM -0800, Paul Gilliam wrote: > +2004-03-01 Paul Gilliam > + > + * lib/gdb.exp: added 'skip_altivec_tests', a modification of > + Janis Johnson's 'check_vmx_hw_available' from GCC testsuite > + * lib/gdb.arch/altivec-abi.exp: use new 'skip_altivec_tests' > + * lib/gdb.arch/altivec-regs.exp: Likewise > + First, please don't include changelogs as diffs. And be careful of tabs. Secondly, this should be: * lib/gdb.exp (skip_altivec_tests): New function, based on check_vmx_hw_available from the GCC testsuite. * lib/gdb.arch/altivec-abi.exp: Use skip_altivec_tests. * lib/gdb.arch/altivec-regs.exp: Likewise. Caps, final periods. > 2004-02-24 Joel Brobecker > > * gdb.ada/fixed_points.exp: Create compilation object directory > diff -Naur testsuite.old/gdb.arch/altivec-abi.exp testsuite/gdb.arch/altivec-abi.exp > --- testsuite.old/gdb.arch/altivec-abi.exp 2005-03-01 14:56:21.484222560 -0800 > +++ testsuite/gdb.arch/altivec-abi.exp 2005-03-01 15:01:49.451289288 -0800 > @@ -32,7 +32,7 @@ > set prms_id 0 > set bug_id 0 > > -if ![istarget "powerpc-*altivec"] then { > +if [skip_altivec_tests] { How about ![istarget "powerpc*-*-*"] || [skip_altivec_tests]? No point compiling the test on i386! > + # Some simulators are known to not support VMX instructions. > + if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] } { > + verbose "check_hw_available returning 0" 2 Please either update the error message, or leave the function named check_vmx_hw_available :-) > + verbose "skip_altivec_testing compiling testfile $src" 1 > + set lines [gdb_compile $src $exe executable {debug additional_flags=-maltivec}] > + file delete $src This is a GCC-only option. Will the tests ever be useful with a non-GCC compiler? If not, please make them fail gracefully before they try to invoke another compiler with -maltivec. See test_compiler_info. > + > + if ![string match "" $lines] then { > + verbose "check_vmx_hw_availalble testfile compilation failed" 2 > + return [set skip_vmx_tests_saved 1] > + } > + > + # No error message, compilation succeeded so now run it. > + > + set exec_result [remote_exec target "./$exe"] > + remote_file build delete "$exe" You just compiled a binary on the build machine and tried to use remote_exec on a target... you're probably not in the same current directory. Have you tried just doing it the same way the GCC testsuite does, using ${tool}_load? -- Daniel Jacobowitz CodeSourcery, LLC