From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18625 invoked by alias); 1 Mar 2005 23:28:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18592 invoked from network); 1 Mar 2005 23:28:54 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 1 Mar 2005 23:28:54 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D6GnK-0007oT-3U; Tue, 01 Mar 2005 18:28:50 -0500 Date: Tue, 01 Mar 2005 23:28:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] test for altivec h/w on PowerPC Message-ID: <20050301232850.GA29883@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200503011519.39739.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503011519.39739.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00010.txt.bz2 On Tue, Mar 01, 2005 at 03:19:39PM -0800, Paul Gilliam wrote: > testsuite/gdb.arch/altivec-abi.exp and testsuite/gdb.arch/altivec-regs.exp > test for relivance by checking if the configuration string ends in 'altivec'. > This wasn't working for me and doesn't seem like the right way to do this. > > So I replaced it by adding a new routine to testsuit/lib/gdb.exp that compiles > and runs a tiny little program. If we are on any machine that doesn't have > altivec hardware, then either the compile fails or the tiny little program > gets an illegal instruction trap when run. This is a modification of a > similar routine in the gcc testsuite. (cut-and-paste code re-use) > > I then changed the two tests mentioned above to use the new routine. > > Ok to commit? Not quite. - You've missed a changelog entry. - You're running a test on the build system instead of the target system. - This code is based on Janis's check_vmx_hw_available from GCC, so you might want to give credit. Incidentally, the original version runs the test on $target... -- Daniel Jacobowitz CodeSourcery, LLC