From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7230 invoked by alias); 24 Feb 2005 20:38:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7206 invoked from network); 24 Feb 2005 20:38:43 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 24 Feb 2005 20:38:43 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D4Pko-0003O1-MK; Thu, 24 Feb 2005 15:38:35 -0500 Date: Thu, 24 Feb 2005 20:53:00 -0000 From: Daniel Jacobowitz To: Orjan Friberg Cc: gdb-patches@sources.redhat.com Subject: Re: [gdbserver/patch] Z packet support Message-ID: <20050224203834.GB11751@nevyn.them.org> Mail-Followup-To: Orjan Friberg , gdb-patches@sources.redhat.com References: <41ADDF6B.2040601@axis.com> <20041207023346.GA2524@nevyn.them.org> <41E52769.2030706@axis.com> <20050130043944.GA25185@nevyn.them.org> <41FF7127.5030604@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41FF7127.5030604@axis.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-02/txt/msg00252.txt.bz2 On Tue, Feb 01, 2005 at 01:08:07PM +0100, Orjan Friberg wrote: > Daniel Jacobowitz wrote: > > > >You missed the most important problem with the previous posting, I'm > >afraid - it's still whitespace mangled. Please don't send patches > >using format=flowed; it's very good for text, but lousy for data. > >Either disable it or just attach them. I've more or less figured out > >the algorithm by which it ate your patch, but it's pretty tedious to > >hand-merge; could you resend? > > Sure. (Until I figure it out, I'll be attaching patches instead of > inlining them. Sorry for the trouble.) > > >CORE_ADDR is always a long long in gdbserver, so your sizeof (addr) > >probably doesn't work right for 32-bit targets. I guess sizeof (void > >*) is always right for this, though... at least for the kinds of > >targets gdbserver supports now. > > FWIW, recurse.exp and watchpoints.exp ran fine on CRISv32 (32-bit target) > when a 64-bit address was sent. I changed it nonetheless, and tweaked the > comment. I was going to implement the matching bits for i386, but never found the time. No point in my holding up your work any longer. I am still not clear on how this will handle threads but it sounds like CRIS kernel bugs mean that that doesn't matter to you; it's irrelevant if you've only got one copy of the debug registers. I may come back to revisit the names of the functions if anyone ever implements hardware breakpoint support. The patch is OK. Please make sure to include a full changelog entry, and update the copyright years in any files you touch. -- Daniel Jacobowitz CodeSourcery, LLC