From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15067 invoked by alias); 18 Feb 2005 21:55:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15010 invoked from network); 18 Feb 2005 21:55:28 -0000 Received: from unknown (HELO priv-edtnes51.telusplanet.net) (199.185.220.223) by sourceware.org with SMTP; 18 Feb 2005 21:55:28 -0000 Received: from takamaka.act-europe.fr ([142.179.108.108]) by priv-edtnes51.telusplanet.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050218215523.EYHO19447.priv-edtnes51.telusplanet.net@takamaka.act-europe.fr> for ; Fri, 18 Feb 2005 14:55:23 -0700 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id AD7E047DBF; Fri, 18 Feb 2005 13:55:22 -0800 (PST) Date: Sat, 19 Feb 2005 12:36:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA] Re: gdb.ada tests broken Message-ID: <20050218215522.GA1200@adacore.com> References: <20050218210459.GA25079@nevyn.them.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="DKU6Jbt7q3WqK7+M" Content-Disposition: inline In-Reply-To: <20050218210459.GA25079@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-02/txt/msg00204.txt.bz2 --DKU6Jbt7q3WqK7+M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 831 > It looks like your changes to use separate subdirectories for each test > has broken separate-objdir testing. My test runs from this morning > have: Oh no, I'm sorry. I thought I had tested my changes with out-of-source builds. Thanks for letting me know. > Does the test script need to create the output directory? Yes, it looks like this would be the best way of fixing the problem. What do you think of the attached patch? 2004-02-18 Joel Brobecker * gdb.ada/fixed_points.exp: Create compilation object directory before running the test. * gdb.ada/null_record.exp: Likewise. * gdb.ada/packed_array.exp: Likewise. * gdb.ada/start.exp: Likewise. Tested on x86-linux using both approaches: one out-of-source build, and one in-tree build. Thanks, -- Joel --DKU6Jbt7q3WqK7+M Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="gdb.ada.diff" Content-length: 2379 Index: fixed_points.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.ada/fixed_points.exp,v retrieving revision 1.2 diff -u -p -r1.2 fixed_points.exp --- fixed_points.exp 3 Feb 2005 03:58:52 -0000 1.2 +++ fixed_points.exp 18 Feb 2005 21:52:11 -0000 @@ -26,6 +26,7 @@ set testfile "${testdir}/fixed_points" set srcfile ${srcdir}/${subdir}/${testfile}.adb set binfile ${objdir}/${subdir}/${testfile} +file mkdir ${objdir}/${subdir}/${testdir} if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { return -1 } Index: null_record.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.ada/null_record.exp,v retrieving revision 1.5 diff -u -p -r1.5 null_record.exp --- null_record.exp 3 Feb 2005 03:58:53 -0000 1.5 +++ null_record.exp 18 Feb 2005 21:52:11 -0000 @@ -26,6 +26,7 @@ set testfile "${testdir}/null_record" set srcfile ${srcdir}/${subdir}/${testfile}.adb set binfile ${objdir}/${subdir}/${testfile} +file mkdir ${objdir}/${subdir}/${testdir} if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { return -1 } Index: packed_array.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.ada/packed_array.exp,v retrieving revision 1.1 diff -u -p -r1.1 packed_array.exp --- packed_array.exp 15 Feb 2005 15:35:26 -0000 1.1 +++ packed_array.exp 18 Feb 2005 21:52:11 -0000 @@ -26,6 +26,7 @@ set testfile "${testdir}/pa" set srcfile ${srcdir}/${subdir}/${testfile}.adb set binfile ${objdir}/${subdir}/${testfile} +file mkdir ${objdir}/${subdir}/${testdir} if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { return -1 } Index: start.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.ada/start.exp,v retrieving revision 1.1 diff -u -p -r1.1 start.exp --- start.exp 9 Feb 2005 19:38:01 -0000 1.1 +++ start.exp 18 Feb 2005 21:52:11 -0000 @@ -26,6 +26,7 @@ set testfile "${testdir}/dummy" set srcfile ${srcdir}/${subdir}/${testfile}.adb set binfile ${objdir}/${subdir}/${testfile} +file mkdir ${objdir}/${subdir}/${testdir} if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { return -1 } --DKU6Jbt7q3WqK7+M--