From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5066 invoked by alias); 17 Feb 2005 16:58:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5001 invoked from network); 17 Feb 2005 16:57:56 -0000 Received: from unknown (HELO priv-edtnes40.telusplanet.net) (199.185.220.224) by sourceware.org with SMTP; 17 Feb 2005 16:57:56 -0000 Received: from takamaka.act-europe.fr ([142.179.108.108]) by priv-edtnes40.telusplanet.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050217165755.KEOA23542.priv-edtnes40.telusplanet.net@takamaka.act-europe.fr>; Thu, 17 Feb 2005 09:57:55 -0700 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 3D8CD47DBF; Thu, 17 Feb 2005 08:57:50 -0800 (PST) Date: Thu, 17 Feb 2005 17:43:00 -0000 From: Joel Brobecker To: Manoj Iyer , gdb-patches@sources.redhat.com, Elena Zannoni Subject: Re: [RFC] Dont skip DW_TAG_member in load_partial_dies() Message-ID: <20050217165750.GJ1200@adacore.com> References: <20050215232018.GB8631@nevyn.them.org> <20050215233503.GB11771@adacore.com> <20050216001647.GA10512@nevyn.them.org> <20050216190824.GU1200@adacore.com> <20050217031805.GE9895@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050217031805.GE9895@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-02/txt/msg00185.txt.bz2 > This sounds like a case that's too complicated for the heuristics to > handle. I have a patch under test which implements a more thorough > fallback when lookup in the hash table fails. That allows the > heuristics to be relatively quick, and work for the common case, but > still support more complex cases like this one. Sounds like a great idea. The reason we didn't submit our changes was that we were also convinced that our solution was not the best approach (we were concerned that we would end up scanning all the symbols, and hence more or less defeating the purpose of partial symbols). Your solution addresses these concerns very nicely. -- Joel