From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25472 invoked by alias); 17 Feb 2005 16:14:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25406 invoked from network); 17 Feb 2005 16:14:25 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 17 Feb 2005 16:14:25 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1HGEP5j025397 for ; Thu, 17 Feb 2005 11:14:25 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1HGEOO13514; Thu, 17 Feb 2005 11:14:24 -0500 Received: from localhost.localdomain (vpnuser34.stuttgart.redhat.com [172.16.4.34]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j1HGEM78012069; Thu, 17 Feb 2005 11:14:23 -0500 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id j1HGEG0V023361; Thu, 17 Feb 2005 09:14:16 -0700 Date: Thu, 17 Feb 2005 17:13:00 -0000 From: Kevin Buettner To: "Levchenko, Vasily V" Cc: gdb-patches@sources.redhat.com Subject: Re: Relative and absolute paths in link_map Message-ID: <20050217091415.1f48a6c1@ironwood.lan> In-Reply-To: <9F0F5F4271FA9140BE3E05452E3BDAFE7F3070@mssmsx403.ccr.corp.intel.com> References: <9F0F5F4271FA9140BE3E05452E3BDAFE7F3070@mssmsx403.ccr.corp.intel.com> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-02/txt/msg00184.txt.bz2 On Thu, 17 Feb 2005 18:20:43 +0300 "Levchenko, Vasily V" wrote: > This is a patch corrects comparing of the shared object names which > could be relative and absolute. > Situation: > To get tls-variable from shared library. Hi Vasily, Thanks for your patch! In the future, please send some sort of context diff, that is, patches generated either with "diff -u" or "diff -C". (I also like it when the "-p" switch is used.) I have read your patch and understand what it is doing, but before putting your change in, I'd first like to understand why it's necessary. Could you offer a bit more explanation about why it is needed? Do you happen to have a small test case? Your patch is small enough that it can likely go in without an FSF copyright assignment. You should know, however, that most patches require some sort of copyright assignment. If you think you might make further contributions to GDB in the future, you should make the proper legal arrangements. If this is something that you're interested in, let me know, and I will ask to have the necessary documents sent to you. Again, I thank you for your patch, and hope that you can provide me with the some sort of test case or at least a description of the scenario in which your patch is needed. Kevin