From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3693 invoked by alias); 16 Feb 2005 03:24:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3679 invoked from network); 16 Feb 2005 03:24:51 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 16 Feb 2005 03:24:51 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D1Fny-0003re-Mo; Tue, 15 Feb 2005 22:24:46 -0500 Date: Wed, 16 Feb 2005 13:04:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [COMMIT] Some amd64-linux-tdep.c tweaks Message-ID: <20050216032446.GA14839@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sources.redhat.com References: <200502160217.j1G2HZ7O019126@copland.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200502160217.j1G2HZ7O019126@copland.sibelius.xs4all.nl> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-02/txt/msg00161.txt.bz2 On Tue, Feb 15, 2005 at 09:17:35PM -0500, Mark Kettenis wrote: > Committed, > > Mark > Hi Mark, Your patch and changelog don't match. Which one's right? > > Index: ChangeLog > from Mark Kettenis > > * amd64-linux-tdep.c: Update copyright year. > (amd64_linux_sigtramp_start): Change argument to `struct > frame_info *'. Use safe_frame_unwind_memory instead of > deprecated_read_memory_nobpt. > (amd64_linux_sigtramp_p): Adjust call to > amd64_linux_sigtramp_start. > > Index: amd64-linux-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/amd64-linux-tdep.c,v > retrieving revision 1.7 > diff -u -p -r1.7 amd64-linux-tdep.c > --- amd64-linux-tdep.c 22 Aug 2004 16:27:30 -0000 1.7 > +++ amd64-linux-tdep.c 16 Feb 2005 02:15:20 -0000 > @@ -1,6 +1,6 @@ > /* Target-dependent code for GNU/Linux x86-64. > > - Copyright 2001, 2003, 2004 Free Software Foundation, Inc. > + Copyright 2001, 2003, 2004, 2005 Free Software Foundation, Inc. > Contributed by Jiri Smid, SuSE Labs. > > This file is part of GDB. > @@ -98,7 +98,7 @@ amd64_linux_sigtramp_start (struct frame > PC is not at the start of the instruction sequence, there will be > a few trailing readable bytes on the stack. */ > > - if (!safe_frame_unwind_memory (next_frame, pc, buf, LINUX_SIGTRAMP_LEN)) > + if (!safe_frame_unwind_memory (next_frame, pc, buf, sizeof buf)) > return 0; > > if (buf[0] != LINUX_SIGTRAMP_INSN0) > @@ -107,8 +107,7 @@ amd64_linux_sigtramp_start (struct frame > return 0; > > pc -= LINUX_SIGTRAMP_OFFSET1; > - > - if (!safe_frame_unwind_memory (next_frame, pc, buf, LINUX_SIGTRAMP_LEN)) > + if (!safe_frame_unwind_memory (next_frame, pc, buf, sizeof buf)) > return 0; > } > > -- Daniel Jacobowitz CodeSourcery, LLC