Re: [commit] Ada-valprint.c const tweaks

[Mark Kettenis <kettenis@gnu.org>]

   Date: Fri, 28 Jan 2005 14:19:48 -0500
   From: Andrew Cagney <cagney@gnu.org>

   FYI,
   Andrew

This patch must be wrong!  In C a string has type 'char *' and the
type of a single character is 'int'.  If your compiler is warning
about incompatible types here, it's got a bug.  This proves that
mindless replacement of 'char' with 'bfd_byte' is a stupid thing to
do.  Please stop it *right* now.

Mark

   2005-01-28  Andrew Cagney  <cagney@gnu.org>

	   * ada-valprint.c (char_at, printstr): Make buffer a const bfd_byte.

   Index: ada-valprint.c
   ===================================================================
   RCS file: /cvs/src/src/gdb/ada-valprint.c,v
   retrieving revision 1.17
   diff -p -u -r1.17 ada-valprint.c
   --- ada-valprint.c	12 Jan 2005 18:31:30 -0000	1.17
   +++ ada-valprint.c	28 Jan 2005 19:16:03 -0000
   @@ -1,7 +1,7 @@
    /* Support for printing Ada values for GDB, the GNU debugger.
   +
       Copyright 1986, 1988, 1989, 1991, 1992, 1993, 1994, 1997, 2001,
   -   2002, 2003, 2004.
   -             Free Software Foundation, Inc.
   +   2002, 2003, 2004, 2005 Free Software Foundation, Inc.

    This file is part of GDB.

   @@ -278,7 +278,7 @@ ada_emit_char (int c, struct ui_file *st
       or 2) of a character.  */

    static int
   -char_at (char *string, int i, int type_len)
   +char_at (const bfd_byte *string, int i, int type_len)
    {
      if (type_len == 1)
	return string[i];
   @@ -439,8 +439,8 @@ ada_print_scalar (struct type *type, LON
     */

    static void
   -printstr (struct ui_file *stream, char *string, unsigned int length,
   -	  int force_ellipses, int type_len)
   +printstr (struct ui_file *stream, const bfd_byte *string,
   +	  unsigned int length, int force_ellipses, int type_len)
    {
      unsigned int i;
      unsigned int things_printed = 0;