From: Daniel Jacobowitz <drow@false.org>
To: Orjan Friberg <orjan.friberg@axis.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: New port: CRISv32
Date: Tue, 25 Jan 2005 15:06:00 -0000 [thread overview]
Message-ID: <20050125150554.GA15407@nevyn.them.org> (raw)
In-Reply-To: <41F65F89.7080404@axis.com>
On Tue, Jan 25, 2005 at 04:02:33PM +0100, Orjan Friberg wrote:
> Daniel Jacobowitz wrote:
> >
> >Those two ChangeLog entries were exactly the same... try again?
>
> The gdbarch.h line was preceded by 8 spaces instead of a tab in the first
> one (my mail client displays them differently). Or did you mean that both
Ah, I couldn't tell the difference.
> looked wrong?
You've got some comma/parentheses confusion at the end of lines. I
believe the GDB convention is to always separate multi-line function
lists with close parens.
--
Daniel Jacobowitz
next prev parent reply other threads:[~2005-01-25 15:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 9:51 Orjan Friberg
2005-01-14 17:42 ` Andrew Cagney
2005-01-25 14:40 ` Orjan Friberg
2005-01-25 14:45 ` Orjan Friberg
2005-01-25 14:48 ` Daniel Jacobowitz
2005-01-25 15:03 ` Orjan Friberg
2005-01-25 15:06 ` Daniel Jacobowitz [this message]
2005-01-25 16:23 ` Orjan Friberg
2005-01-25 17:03 ` Daniel Jacobowitz
2005-01-25 16:08 ` Andrew Cagney
2005-01-25 16:28 ` Orjan Friberg
2005-01-25 16:39 ` Andrew Cagney
2005-01-26 12:36 ` Orjan Friberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125150554.GA15407@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=orjan.friberg@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox