Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: orjan.friberg@axis.com
Cc: gdb-patches@sources.redhat.com, kettenis@gnu.org,
	hans-peter.nilsson@axis.com
Subject: Re: [CRIS] Reading core file selects "wrong" mach
Date: Fri, 14 Jan 2005 18:40:00 -0000	[thread overview]
Message-ID: <200501141840.j0EIe674031391@ignucius.se.axis.com> (raw)
In-Reply-To: <41E7FD09.4000002@axis.com> (message from Orjan Friberg on Fri, 14 Jan 2005 18:10:33 +0100)

> Date: Fri, 14 Jan 2005 18:10:33 +0100
> From: Orjan Friberg <orjanf@axis.com>

> Maybe there's an easier way to do it - simply call the elf backend before 
> processing the program headers, and have the backend set the correct machine 
> like they all seem to do already.  Since the decision of whether to act on the 
> e_flags value is pushed to the elf backend I don't see how this could break 
> anything (which I assume could happen if it was done in elf_core_file_p).

Sure.  Seems right at a glance, but you should check
elf_backend_object_p of all ports so they don't use data set in
the code around which you moved the call.

> I understand this will have to be sent to the binutils mailing list for 
> approval, but I'd appreciate if someone on this list could tell me if it's a 
> sane solution.

The people at binutils@ are supposedly more aware of issues
related to this kind of change, meaning you're likely to get
more initiated feedback there regarding the saneness.

mvh H-P


      reply	other threads:[~2005-01-14 18:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-01 14:00 Orjan Friberg
2004-12-01 16:14 ` Randolph Chung
2004-12-02 10:15   ` Orjan Friberg
2004-12-02 15:42     ` Randolph Chung
2004-12-02 17:18 ` Mark Kettenis
2004-12-13 15:12   ` Orjan Friberg
2004-12-13 16:09     ` Hans-Peter Nilsson
2004-12-13 20:22     ` Mark Kettenis
2005-01-14 17:10   ` Orjan Friberg
2005-01-14 18:40     ` Hans-Peter Nilsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501141840.j0EIe674031391@ignucius.se.axis.com \
    --to=hans-peter.nilsson@axis.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@gnu.org \
    --cc=orjan.friberg@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox