From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: cagney@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Re-implement exceptions.c using a state m/c
Date: Wed, 12 Jan 2005 21:20:00 -0000 [thread overview]
Message-ID: <200501122119.j0CLJuDF017482@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <41E57768.906@gnu.org> (message from Andrew Cagney on Wed, 12 Jan 2005 14:15:52 -0500)
Date: Wed, 12 Jan 2005 14:15:52 -0500
From: Andrew Cagney <cagney@gnu.org>
Hello,
This rewrites the throw / catch code to use a state machine and a
linked list of catchers (instead of stack-local variables). There
are no external interface changes.
Hmm, on my i386-unknown-freebsd4.7 system I'm getting:
gcc -c -g -O2 -I. -I../../src/gdb -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl -DMI_OUT=1 -DTUI=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Wformat-nonliteral -Werror ../../src/gdb/exceptions.c
cc1: warnings being treated as errors
../../src/gdb/exceptions.c: In function `catch_exceptions_with_msg':
../../src/gdb/exceptions.c:315: warning: variable `val' might be clobbered by `longjmp' or `vfork'
../../src/gdb/exceptions.c: In function `catch_errors':
../../src/gdb/exceptions.c:333: warning: variable `val' might be clobbered by `longjmp' or `vfork'
gmake[1]: *** [exceptions.o] Error 1
gmake[1]: Leaving directory `/home/kettenis/sandbox/gdb/obj/gdb'
gmake: *** [all-gdb] Error 2
This is with gcc 2.95.4. I can't say I blame the compiler for losing
track here; I can't establish for myself whether there's an actual
problem here or not.
Andrew, can you please rwerite the code such that it becomes a bit
easier to follow?
Thanks,
Mark
prev parent reply other threads:[~2005-01-12 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 19:17 Andrew Cagney
2005-01-12 20:38 ` Eli Zaretskii
2005-01-12 21:20 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501122119.j0CLJuDF017482@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox