From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA/pa-risc] Correct incorrect frame base
Date: Sat, 01 Jan 2005 12:31:00 -0000 [thread overview]
Message-ID: <20050101123102.GP1824@adacore.com> (raw)
In-Reply-To: <20041231161258.GA4437@nevyn.them.org>
> On Fri, Dec 31, 2004 at 07:14:15PM +0400, Joel Brobecker wrote:
> > There is a small confusion in the source register for the addil
> > instruction. The actual sequence should be
> >
> > addil high21,%r30
> > ldo low11(%r1),%r30
> >
> > I think the confusion comes from the fact that the result of
> > the sum is stored in %r1.
>
> "addil <number>,%r30" sets %r1 and not %r30?
Yes. "addil high21,%rn" adds high21 to register n, and then always
stores the results in r1.
> Whose bright idea was that, anyway?
:-)
> > 2004-12-31 Joel Brobecker <brobecker@gnat.com>
> >
> > * hppa-tdep.c (prologue_inst_adjust_sp): Fix small confusion
> > in register number for ldil instruction.
> >
> > Tested on HP/UX 11.00, no regression.
> > OK to apply?
>
> OK. Typo in the changelog: that's addil, not ldil, isn't it?
Good catch, sorry for the confusion. Fixed and checked in.
Thank you!
--
Joel
next prev parent reply other threads:[~2005-01-01 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-31 16:13 Joel Brobecker
[not found] ` <20041231161258.GA4437@nevyn.them.org>
2005-01-01 12:31 ` Joel Brobecker [this message]
2005-01-04 0:09 John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050101123102.GP1824@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox