Re: [RFA] Add parse_dwarf2_calling_convention functionality

Elena Zannoni
2004-10-22T03:31:51Z

Corinna Vinschen writes:
> Hi,
>
> On Oct 7 11:54, Corinna Vinschen wrote:
> > the second patch to prepare the calling convention stuff. It just adds
> > the parse_dwarf2_calling_convention functionality to gdbarch. The
> > below patch contains only the patch to gdbarch.sh (not the auto-generated
> > gdbarch.[ch]) and the new default_parse_dwarf2_calling_convention function
> > in arch-utils.
>
> Corrected patch below. It seems to be more useful to use the producer
> field of the compilation unit instead of an artificial "gcc_compiled"
> flag. The producer string is easily scanned and the information given
> is more detailed than just a gcc_compiled flag.
>
> The below patch overrides the previous patch and also contains the
> necessary change to dwarf2read.c now.
>
> Corinna
>
> * gdbarch.sh (parse_dwarf2_calling_convention): New method.
> * gdbarch.h, gdbarch.c: Re-generate.
> * arch-utils.c (default_parse_dwarf2_calling_convention): New function.
> * arch-utils.h (default_parse_dwarf2_calling_convention): New extern
> declaration.
> * dwarf2read.c (read_subroutine_type): Evaluate
> DW_AT_calling_convention attribute and call
> gdbarch_parse_dwarf2_calling_convention appropriately.

The dwarf2read.c part is approved if the rest gets approved.