Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/alpha-osf] another next frame confusion in signal unwinder?
Date: Mon, 13 Dec 2004 08:43:00 -0000	[thread overview]
Message-ID: <20041213051102.GF999@adacore.com> (raw)
In-Reply-To: <41BC67C0.6080106@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

> (I need to deprecate get frame base).  Can you just tweak this to return 
> get_frame_id().stack_addr before committing.

Sure. Attached is what I ended up checking in.

2004-12-13  Joel Brobecker  <brobecker@gnat.com>

        * alpha-osf1-tdep.c (alpha_osf1_sigcontext_addr): Change
        parameter name to make it clear that we already have a next
        frame.  Return the sigcontext from that next frame instead
        of the frame following it.

Thanks,
-- 
Joel

[-- Attachment #2: osf.diff --]
[-- Type: text/plain, Size: 869 bytes --]

Index: alpha-osf1-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-osf1-tdep.c,v
retrieving revision 1.18
diff -u -p -r1.18 alpha-osf1-tdep.c
--- alpha-osf1-tdep.c	1 May 2004 15:34:49 -0000	1.18
+++ alpha-osf1-tdep.c	13 Dec 2004 05:04:53 -0000
@@ -35,14 +35,11 @@ alpha_osf1_pc_in_sigtramp (CORE_ADDR pc,
 }
 
 static CORE_ADDR
-alpha_osf1_sigcontext_addr (struct frame_info *frame)
+alpha_osf1_sigcontext_addr (struct frame_info *next_frame)
 {
-  struct frame_info *next_frame = get_next_frame (frame);
+  const struct frame_id next_id = get_frame_id (next_frame);
 
-  if (next_frame != NULL)
-    return (read_memory_integer (get_frame_base (next_frame), 8));
-  else
-    return (read_memory_integer (get_frame_base (frame), 8));
+  return (read_memory_integer (next_id.stack_addr, 8));
 }
 
 static void

      reply	other threads:[~2004-12-13  5:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-01 23:51 Joel Brobecker
2004-12-12 16:27 ` Andrew Cagney
2004-12-13  8:43   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041213051102.GF999@adacore.com \
    --to=brobecker@adacore.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox