Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Randolph Chung <randolph@tausq.org>
To: Mark Kettenis <kettenis@gnu.org>
Cc: brobecker@adacore.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA/hppa] unwind pc in bottom frame using correct register
Date: Wed, 08 Dec 2004 08:21:00 -0000	[thread overview]
Message-ID: <20041208061238.GL6359@tausq.org> (raw)
In-Reply-To: <20041208032725.GI6359@tausq.org>

> hrm, something is broken. on hppa64-hp-hpux11.11 this is causing a lot
> of unwinding failures. the hpux unwind_pc method is getting flags that
> have the magic "2" bit set, so it gets the pc from 31 instead of the
> pcoqh register.

figured it out.. we were only clearing the first half of the register on
64-bit... i committed the following patch to fix the problem.

randolph
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/


2004-12-07  Randolph Chung  <tausq@debian.org>

	* hppa-tdep.c (hppa_frame_prev_register_helper): Zero out the entire
	register for both 32- and 64-bit targets.

Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.188
diff -u -p -r1.188 hppa-tdep.c
--- hppa-tdep.c	8 Dec 2004 01:48:02 -0000	1.188
+++ hppa-tdep.c	8 Dec 2004 06:09:45 -0000
@@ -2459,7 +2467,10 @@ hppa_frame_prev_register_helper (struct 
   if (regnum == HPPA_FLAGS_REGNUM)
     {
       if (valuep)
-	store_unsigned_integer (valuep, 4, 0);
+	store_unsigned_integer (valuep, 
+			        register_size (get_frame_arch (next_frame), 
+					       regnum), 
+				0);
 
       /* It's a computed value.  */
       *optimizedp = 0;


  reply	other threads:[~2004-12-08  6:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-04  5:31 Joel Brobecker
2004-12-04  7:51 ` Randolph Chung
2004-12-04  8:46   ` Joel Brobecker
2004-12-04 10:53     ` Randolph Chung
2004-12-04 12:42       ` Mark Kettenis
2004-12-08  4:33         ` Randolph Chung
2004-12-08  8:21           ` Randolph Chung [this message]
2004-12-08 22:20             ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041208061238.GL6359@tausq.org \
    --to=randolph@tausq.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox