From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19831 invoked by alias); 7 Dec 2004 18:08:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19786 invoked from network); 7 Dec 2004 18:08:12 -0000 Received: from unknown (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 7 Dec 2004 18:08:12 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id iB7I85G9022786; Tue, 7 Dec 2004 19:08:05 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id iB7I85mR002562; Tue, 7 Dec 2004 19:08:05 +0100 (CET) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id iB7I851U002559; Tue, 7 Dec 2004 19:08:05 +0100 (CET) Date: Tue, 07 Dec 2004 18:24:00 -0000 Message-Id: <200412071808.iB7I851U002559@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: randolph@tausq.com, gdb-patches@sources.redhat.com In-reply-to: <20041207100749.GB2524@adacore.com> (message from Joel Brobecker on Tue, 7 Dec 2004 11:07:49 +0100) Subject: Re: [RFA/RFC] Improve hppa PC reading/unwinding References: <200412052004.iB5K4TlY001778@elgar.sibelius.xs4all.nl> <20041207100749.GB2524@adacore.com> X-SW-Source: 2004-12/txt/msg00207.txt.bz2 Date: Tue, 7 Dec 2004 11:07:49 +0100 From: Joel Brobecker > Index: ChangeLog > from Mark Kettenis > > * hppa-tdep.h (hppa_read_pc, hppa_write_pc, hppa_unwind_pc): New > prototypes. > * hppa-tdep.c (hppa_read_pc): Rename from hppa_target_read_pc. > Make global. Remove HP-UX specific code. > (hppa_write_pc): Rename from hppa_target_write_pc. Make global. > Remove HP-UX specific code. > (hppa_unwind_pc): Make global. Remove HP-UX specific code. > (hppa_frame_prev_register_helper): Set "flags" register to zero > for all unwound frames. > (hppa_gdbarch_init): Adjust. > * hppa-hpux-tdep.c (HPPA_HPUX_SS_INSYSCALL): New define. > (hppa_hpux_read_pc, hppa_hpux_write_pc) > (hppa_hpux_unwind_pc): New functions. > (hppa_hpux_init_abi): Set read_pc, write_pc and unwind_pc. I read the patch, and also tested it with the little example I posted in the thread you mentioned, and found that it fixed the problem. I also did a bit of sanity checking and it looks good. I can also test this change against the testsuite if necessary. Nah, I ran the testsuite myself. Went ahead and committed it. Mark