Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc] first cut of solib-som.[ch]
Date: Wed, 08 Dec 2004 00:02:00 -0000	[thread overview]
Message-ID: <20041207162726.030bb7cc.kevinb@redhat.com> (raw)
In-Reply-To: <20041207230816.GE6359@tausq.org>

On Tue, 7 Dec 2004 15:08:16 -0800
Randolph Chung <randolph@tausq.org> wrote:

> > I'm comfortable with either approach.  It makes a certain amount of
> > sense to initialize the solib related portions of the tdep struct from
> > within a solib-*.c file.  OTOH, it also makes sense to not clutter the
> > solib-*.c file with knowledge of a particular architecture's tdep
> > struct.  In this case, solib-som.c will probably not be used by any
> > other architectures, so it doesn't make much difference.  I'll leave
> > it to you to choose the approach which you like better.
> 
> well, for me it boils down to a dependency problem, which is still a bit
> tricky at the moment.
> 
> what i would like to see is:
> 32-bit hpux targets will build only solib-som.*, and only support 32-bit
> 	debugging
> 64-bit hpux targets will build both solib-som.* and solib-pa64.*, and
> 	support both 32-bit and 64-bit debugging
> 
> the problem in this scenario is that in the common hpux file (i.e.
> hppa-hpux-tdep.c), in order to support both configurations, we cannot
> refer to anything that is in solib-pa64.*.
> 
> this is already a problem if i need to call e.g. pa64_solib_select (),
> and it becomes worse if we expose the solib methods to the tdep file.

Thanks for explaining this.  Given this background, I think that your
original approach of initializing a portion of the tdep struct from
within solib-*.c is preferable.

> i'm thinking that the best way to do this is:
> - have the 32-bit hpux configs define PA_SOM_ONLY (as they do now)
> - unconditionally build both solib-som.c and solib-pa64.c into all hpux
>   targets
> - in solib-pa64.c, make everything compile out if PA_SOM_ONLY is
>   defined, except for a stub pa64_solib_select ()
> 
> is there a cleaner way?

I can't think of one at the moment.  So... go ahead with this approach.

Kevin


  reply	other threads:[~2004-12-07 23:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-07  9:10 Randolph Chung
2004-12-07 17:31 ` Kevin Buettner
2004-12-07 21:41   ` Randolph Chung
2004-12-07 22:18     ` Kevin Buettner
2004-12-07 23:27       ` Randolph Chung
2004-12-08  0:02         ` Kevin Buettner [this message]
2004-12-08  1:44           ` [commit] First cut of SOM and PA64 solib support Randolph Chung
2004-12-08  4:46             ` Kevin Buettner
2004-12-08  5:28             ` Eli Zaretskii
2004-12-08  6:12               ` Randolph Chung
2004-12-08 20:01                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041207162726.030bb7cc.kevinb@redhat.com \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox