Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@gnu.org>
To: kevinb@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Generic support for qGetTLSAddr packet
Date: Mon, 06 Dec 2004 22:51:00 -0000	[thread overview]
Message-ID: <200412062237.iB6MbIGY000533@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20041206143109.7e29789f.kevinb@redhat.com> (message from Kevin Buettner on Mon, 6 Dec 2004 14:31:09 -0700)

   Date: Mon, 6 Dec 2004 14:31:09 -0700
   From: Kevin Buettner <kevinb@redhat.com>

Since you asked for comments ;-):

Yikes!  That qGetTLSAddr in the function name is really ugly.

That said, I don't understand why there's any need for the remote code
to get so deep into the core GDB code.  I don't see the big picture
yet, but my initial reaction is that this must be wrong.  Why does the
remote protocol need to know more than a native GDB?

   The patch below implements support for the qGetTLSAddr packet.  See:

       http://sources.redhat.com/ml/gdb/2004-11/msg00189.html

   This patch also adds a new gdbarch method for fetching the OS / ABI
   specific load module parameters.

I don't think this should be added to the "glibal" gdbbarch vector.
Instead, this probably should be architecture-dependent data that's
only known to the remote protocol module.

Mark


  reply	other threads:[~2004-12-06 22:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-06 21:57 Kevin Buettner
2004-12-06 22:51 ` Mark Kettenis [this message]
2004-12-06 23:06   ` Daniel Jacobowitz
2004-12-08  0:24     ` Kevin Buettner
2004-12-08  0:38       ` Kevin Buettner
2004-12-08  1:39         ` Daniel Jacobowitz
2004-12-06 23:46   ` Kevin Buettner
2004-12-12 18:17 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200412062237.iB6MbIGY000533@elgar.sibelius.xs4all.nl \
    --to=kettenis@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox