From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20328 invoked by alias); 6 Dec 2004 03:36:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20311 invoked from network); 6 Dec 2004 03:36:21 -0000 Received: from unknown (HELO arwen.tausq.org) (64.81.244.109) by sourceware.org with SMTP; 6 Dec 2004 03:36:21 -0000 Received: by arwen.tausq.org (Postfix, from userid 1000) id 6735C111F48; Sun, 5 Dec 2004 19:36:18 -0800 (PST) Date: Mon, 06 Dec 2004 03:40:00 -0000 From: Randolph Chung To: gdb-patches@sources.redhat.com Subject: [commit] cleanup use of DEPRECATED_REGISTER_BYTE in hppah-nat.c Message-ID: <20041206033618.GD6359@tausq.org> Reply-To: Randolph Chung Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GPG: for GPG key, see http://www.tausq.org/gpg.txt User-Agent: Mutt/1.5.6+20040722i X-SW-Source: 2004-12/txt/msg00149.txt.bz2 Small cleanup while i was looking at the hpux code.... committed as obvious. randolph 2004-12-05 Randolph Chung * hppah-nat.c (store_inferior_registers): Rewrite logic to not use DEPRECATED_REGISTER_BYTE. Index: hppah-nat.c =================================================================== RCS file: /cvs/src/src/gdb/hppah-nat.c,v retrieving revision 1.35 diff -u -p -r1.35 hppah-nat.c --- hppah-nat.c 20 Nov 2004 23:56:18 -0000 1.35 +++ hppah-nat.c 6 Dec 2004 03:33:26 -0000 @@ -114,8 +114,9 @@ store_inferior_registers (int regno) /* Floating-point registers come from the ss_fpblock area. */ else if (regno >= HPPA_FP0_REGNUM) - addr = (HPPAH_OFFSETOF (save_state_t, ss_fpblock) - + (DEPRECATED_REGISTER_BYTE (regno) - DEPRECATED_REGISTER_BYTE (HPPA_FP0_REGNUM))); + addr = HPPAH_OFFSETOF (save_state_t, ss_fpblock) + + ((regno - HPPA_FP0_REGNUM) + * register_size (current_gdbarch, regno)); /* Wide registers come from the ss_wide area. I think it's more PC to test (ss_flags & SS_WIDEREGS) to select @@ -123,14 +124,14 @@ store_inferior_registers (int regno) But checking ss_flags would require an extra ptrace call for every register reference. Bleah. */ else if (len == 8) - addr = (HPPAH_OFFSETOF (save_state_t, ss_wide) - + DEPRECATED_REGISTER_BYTE (regno)); + addr = HPPAH_OFFSETOF (save_state_t, ss_wide) + + regno * 8; /* Narrow registers come from the ss_narrow area. Note that ss_narrow starts with gr1, not gr0. */ else if (len == 4) - addr = (HPPAH_OFFSETOF (save_state_t, ss_narrow) - + (DEPRECATED_REGISTER_BYTE (regno) - DEPRECATED_REGISTER_BYTE (1))); + addr = HPPAH_OFFSETOF (save_state_t, ss_narrow) + + (regno - 1) * 4; else internal_error (__FILE__, __LINE__, "hppah-nat.c (write_register): unexpected register size"); -- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/