From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9121 invoked by alias); 4 Dec 2004 15:47:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9006 invoked from network); 4 Dec 2004 15:47:17 -0000 Received: from unknown (HELO cmailg3.svr.pol.co.uk) (195.92.195.173) by sourceware.org with SMTP; 4 Dec 2004 15:47:17 -0000 Received: from modem-2582.buffalo.dialup.pol.co.uk ([217.134.74.22] helo=merlin.buzzard.freeserve.co.uk) by cmailg3.svr.pol.co.uk with esmtp (Exim 4.41) id 1Cac7v-0004Ya-K2 for gdb-patches@sources.redhat.com; Sat, 04 Dec 2004 15:47:16 +0000 Received: from merlin (localhost [127.0.0.1]) by merlin.buzzard.freeserve.co.uk (8.12.11/8.12.11) with ESMTP id iB4FkOnI002858; Sat, 4 Dec 2004 15:46:24 GMT Message-Id: <200412041546.iB4FkOnI002858@merlin.buzzard.freeserve.co.uk> To: Richard Earnshaw , gdb-patches@sources.redhat.com From: Richard Earnshaw Subject: Re: RFA fix conversion of little-byte big-word floats to doublest In-reply-to: <20041204154429.GA2764@nevyn.them.org> References: <20041204154429.GA2764@nevyn.them.org> <200412041438.iB4Ec0cq017568@merlin.buzzard.freeserve.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 04 Dec 2004 16:01:00 -0000 X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on merlin.buzzard.freeserve.co.uk X-SW-Source: 2004-12/txt/msg00113.txt.bz2 On Sat, 04 Dec 2004 10:44:30 EST, Daniel Jacobowitz wrote: > On Sat, Dec 04, 2004 at 02:38:00PM +0000, Richard Earnshaw wrote: > > > > This patch fixes a bug in get_field which meant that we incorrectly > > converted mixed-endian floats (ARM FPA style) into the internal doublest > > format. This short change fixes over 300 testsuite failures in a combined > > arm/thumb testsuite run on arm-elf. > > > > * doublest.c (get_field): Correctly extract floatformat_littebyte_bigwo > rd > > fields. > > > > OK? > > Could you summarize for me how this is supposed to work? This means > that get_field treats littlebyte_bigword exactly the same as little. > There's another copy of get_field in libiberty (I don't know why there > are two) which treats it exactly the same as big, instead. I don't > know how that works either, but it seems the two ought to agree. The caller has pre-converted the word order into a pure little-endian format. See convert_format_to_doublest. Similar tricks are played on the reverse conversion. R.