From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14483 invoked by alias); 1 Dec 2004 05:13:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14469 invoked from network); 1 Dec 2004 05:13:43 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 1 Dec 2004 05:13:43 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CZMoB-0001e6-4S; Wed, 01 Dec 2004 00:13:43 -0500 Date: Wed, 01 Dec 2004 05:13:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/alpha] Fix problem loading core files Message-ID: <20041201051343.GA6267@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20041201043106.GP1204@adacore.com> <20041201045725.GQ1204@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041201045725.GQ1204@adacore.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-12/txt/msg00010.txt.bz2 On Tue, Nov 30, 2004 at 08:57:25PM -0800, Joel Brobecker wrote: > This patch modified alpha_cannot_fetch_register() and > alpha_cannot_store_register() to exclude the register which > have an empty name. These empty names are the sign of a register > number that is no longer used, but has been reserved to maintain > compatibility with remote debug agents. It's late, your English grammar is slipping :-) Patch is OK with a couple of corrections. > 2004-11-30 Joel Brobecker > > * alpha-tdep.c (alpha_register_name): Add comment. > (alpha_cannot_fetch_register): Exclude register number which > are no longer used from the list of registers that can be fetched. > (alpha_cannot_store_register): Exclude register number which > are no longer used from the list of registers that can be stored. s/register number/register numbers/ > +/* Return the name of the REGNO register. > + > + An empty name correspond to a register number that used to s/correspond/corresponds/ -- Daniel Jacobowitz