Re: [RFA/testsuite/ada] Put testcase code in own directory

Daniel Jacobowitz
2004-12-01T04:54:25Z

On Tue, Nov 30, 2004 at 07:20:21PM -0800, Joel Brobecker wrote:
> Michael,
>
> > nothing for or against this. However it's strategic decision - one for
> > MichaelC - should for package like languages such as ada (and for that
> > matter java) we have a directory per test? :-)
>
> In reviewing this patch, I see that there are some pieces that I forgot
> to include. So the patch can not be accepted as is.
>
> However, would you mind telling us what you think about the principle?
> If you want my opinion, I am strongly attached to the idea of having
> one subdirectory per testcase. The current approach used for C where
> you can pretty much always have all the code for one testcase stored
> in one .c file simply does not work for Ada. With GNAT, you need the
> filename to match the name of the unit, and you need to have one and
> only one unit per file[1]. Most testcases will involve at least 3 files,
> one containing the main procedure (that one compilation unit), plus
> a .ads file containing the spec of a package, plus a .adb file
> containing the body of a package. Some testcases will use many
> more files than this (we have one testcase internally that creates
> something like 200 packages).
>
> For maintenance reasons, I really feel that one subdirectory per
> testcase is the way to go.
>
> I hope you'll agree with me, in which case I'll work on producing
> a new iteration of this patch, complete this time.

Well, it seems reasonable to me.

I'd even go a step further and put multi-file C tests into their own
directories. That may be overkill, though.

--
Daniel Jacobowitz