From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25563 invoked by alias); 1 Dec 2004 04:54:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25541 invoked from network); 1 Dec 2004 04:54:22 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 1 Dec 2004 04:54:22 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CZMVM-0001Xn-NE; Tue, 30 Nov 2004 23:54:16 -0500 Date: Wed, 01 Dec 2004 04:54:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Michael Elizabeth Chastain , Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite/ada] Put testcase code in own directory Message-ID: <20041201045416.GB5872@nevyn.them.org> Mail-Followup-To: Joel Brobecker , Michael Elizabeth Chastain , Andrew Cagney , gdb-patches@sources.redhat.com References: <20041108211630.GD649@gnat.com> <41939655.7070503@gnu.org> <20041201032021.GG1204@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041201032021.GG1204@adacore.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-12/txt/msg00007.txt.bz2 On Tue, Nov 30, 2004 at 07:20:21PM -0800, Joel Brobecker wrote: > Michael, > > > nothing for or against this. However it's strategic decision - one for > > MichaelC - should for package like languages such as ada (and for that > > matter java) we have a directory per test? :-) > > In reviewing this patch, I see that there are some pieces that I forgot > to include. So the patch can not be accepted as is. > > However, would you mind telling us what you think about the principle? > If you want my opinion, I am strongly attached to the idea of having > one subdirectory per testcase. The current approach used for C where > you can pretty much always have all the code for one testcase stored > in one .c file simply does not work for Ada. With GNAT, you need the > filename to match the name of the unit, and you need to have one and > only one unit per file[1]. Most testcases will involve at least 3 files, > one containing the main procedure (that one compilation unit), plus > a .ads file containing the spec of a package, plus a .adb file > containing the body of a package. Some testcases will use many > more files than this (we have one testcase internally that creates > something like 200 packages). > > For maintenance reasons, I really feel that one subdirectory per > testcase is the way to go. > > I hope you'll agree with me, in which case I'll work on producing > a new iteration of this patch, complete this time. Well, it seems reasonable to me. I'd even go a step further and put multi-file C tests into their own directories. That may be overkill, though. -- Daniel Jacobowitz