From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6628 invoked by alias); 29 Nov 2004 15:26:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5918 invoked from network); 29 Nov 2004 15:25:43 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 29 Nov 2004 15:25:43 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CYnPK-0008Qt-0d; Mon, 29 Nov 2004 10:25:42 -0500 Date: Mon, 29 Nov 2004 15:26:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Jerome Guitton , gdb-patches@sources.redhat.com, Elena Zannoni Subject: Re: [RFA/testsuite] Ada fixed points [was stabs: octal negative numbers] Message-ID: <20041129152541.GA32206@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Jerome Guitton , gdb-patches@sources.redhat.com, Elena Zannoni References: <20041026173953.GA31663@act-europe.fr> <20041123140912.GA16691@adacore.com> <16803.18707.377459.922918@localhost.redhat.com> <20041123143812.GJ15300@adacore.com> <20041125192038.GA20252@adacore.com> <20041128174901.GD24639@nevyn.them.org> <20041129102424.GJ20670@adacore.com> <20041129134231.GA29157@nevyn.them.org> <41AB3E1D.90306@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41AB3E1D.90306@gnu.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-11/txt/msg00520.txt.bz2 On Mon, Nov 29, 2004 at 10:19:57AM -0500, Andrew Cagney wrote: > Daniel Jacobowitz wrote: > >On Mon, Nov 29, 2004 at 11:24:24AM +0100, Jerome Guitton wrote: > > > >>Daniel Jacobowitz (drow@false.org): > >> > >> > >>>Please don't hardcode "run". Can you use > >>>"runto ${srcfile}:$bp_location" > >>>instead of these two lines? > >> > >>>Please add a copyright notice to this file. > >> > >>Daniel, > >> > >>Thank you for your review. I fixed these two problems; new files in > >>attachment. OK now? > > > > > >Yes, this testcase is OK. Thanks! > > Sigh. > > Jerome, Daniel, > > If this test is instead added to the gdb.stabs directory we'll get far > better mileage - few, if anyone, has an Ada compiler, yet almost > everyone has the ability to build/run the gdb.stabs testsuite. Personally, I run the Ada tests every time I build GDB. If you'd like to hand-write a stabs test, of course, that'd be a nice complement to the Ada test. -- Daniel Jacobowitz