From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12357 invoked by alias); 23 Nov 2004 19:33:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12030 invoked from network); 23 Nov 2004 19:33:25 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 23 Nov 2004 19:33:25 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id iANJXLG3026123; Tue, 23 Nov 2004 20:33:21 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id iANJXLs0013953; Tue, 23 Nov 2004 20:33:21 +0100 (CET) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id iANJXHtx013950; Tue, 23 Nov 2004 20:33:17 +0100 (CET) Date: Tue, 23 Nov 2004 19:33:00 -0000 Message-Id: <200411231933.iANJXHtx013950@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: randolph@tausq.org CC: cagney@gnu.org, gdb-patches@sources.redhat.com In-reply-to: <20041123174937.GL9148@tausq.org> (message from Randolph Chung on Tue, 23 Nov 2004 09:49:37 -0800) Subject: Re: [patch/RFA] multiarch INSTRUCTION_NULLIFIED References: <20041118000159.GG15714@tausq.org> <419CB118.7080401@gnu.org> <20041118162108.GK15714@tausq.org> <200411181655.iAIGthDa026050@juw15.nfra.nl> <20041123174937.GL9148@tausq.org> X-SW-Source: 2004-11/txt/msg00453.txt.bz2 Date: Tue, 23 Nov 2004 09:49:37 -0800 From: Randolph Chung i did some more investigations.... turns out this is not a cosmetic piece of code at all :) suppose we have a function that ended with a branch-with-nullify-next instruction back to the caller. if you did a "step" on the branch, and we don't skip the nullified instruction, we would end up on the nullified instruction which actually belongs to the next function. comments? ok to check in? OK, if you make sure you wrap the lines that are too long. Mark 2004-11-23 Randolph Chung * arch-utils.c (generic_instruction_nullified): New. * arch-utils.h (generic_instruction_nullified): New. * gdbarch.sh (instruction_nullified): New method. * gdbarch.c: Regenerate. * gdbarch.h: Regenerate. * infrun.c (INSTRUCTION_NULLIFIED): Delete. (handle_inferior_event): Replace INSTRUCTION_NULLIFIED with calls to new gdbarch method. * config/pa/tm-hppa.h (INSTRUCTION_NULLIFIED): Delete definition. * hppa-tdep.c (hppa_instruction_nullified): Remove prototype and make static. Rewrite to work directly off the passed regcache. (hppa_gdbarch_init): Set instruction_nullified method.