Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Randolph Chung <randolph@tausq.org>
To: gdb-patches@sources.redhat.com
Subject: [patch] relax test in gdb.base/commands.exp
Date: Mon, 22 Nov 2004 23:29:00 -0000	[thread overview]
Message-ID: <20041122232915.GG9148@tausq.org> (raw)

The regexp below checked for a specific line number in the caller when
the watchpoint goes out of scope. On a target that emulates watchpoints
with single stepping i've seen that we get the "watchpoint deleted"
message when we're in the epilogue of a function. in this case the
current line number may still be in the called function. This patch
relaxes the line number checking a bit so we allow both cases (but not
any random line). Tested on hppa-linux. ok?

randolph



2004-11-22  Randolph Chung  <tausq@debian.org>

testsuite/
	* gdb.base/commands.exp (watchpoint_command_test): Relax line number 
	check to allow line number inside the called function.

Index: testsuite/gdb.base/commands.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/commands.exp,v
retrieving revision 1.13
diff -u -p -r1.13 commands.exp
--- testsuite/gdb.base/commands.exp	29 Sep 2003 15:08:52 -0000	1.13
+++ testsuite/gdb.base/commands.exp	22 Nov 2004 23:18:02 -0000
@@ -331,7 +331,7 @@ proc watchpoint_command_test {} {
     }
     send_gdb "continue\n"
     gdb_expect {
-	-re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the program has left the block in.*which its expression is valid.*run.c:57.*$gdb_prompt $" {
+	-re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the program has left the block in.*which its expression is valid.*run.c:\(57|82\).*$gdb_prompt $" {
 	    pass "continue with watch"
 	}
 	-re "$gdb_prompt $"   {fail "continue with watch"}
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/


             reply	other threads:[~2004-11-22 23:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-22 23:29 Randolph Chung [this message]
2004-11-28 17:43 ` Daniel Jacobowitz
2004-11-28 19:19   ` Randolph Chung
2004-12-01  8:07   ` Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041122232915.GG9148@tausq.org \
    --to=randolph@tausq.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox