From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31206 invoked by alias); 20 Nov 2004 17:41:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31088 invoked from network); 20 Nov 2004 17:41:07 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 20 Nov 2004 17:41:07 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id iAKHf4K4017329; Sat, 20 Nov 2004 18:41:04 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id iAKHf4s0001477; Sat, 20 Nov 2004 18:41:04 +0100 (CET) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id iAKHf0CV001472; Sat, 20 Nov 2004 18:41:00 +0100 (CET) Date: Sat, 20 Nov 2004 17:41:00 -0000 Message-Id: <200411201741.iAKHf0CV001472@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: eliz@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <01c4cf25$Blat.v2.2.2$44ec6860@zahav.net.il> (eliz@gnu.org) Subject: Re: [COMMIT] Improve coding standard in dbxread.c References: <200411201239.iAKCd9O5061792@elgar.sibelius.xs4all.nl> <01c4cf25$Blat.v2.2.2$44ec6860@zahav.net.il> X-SW-Source: 2004-11/txt/msg00405.txt.bz2 Date: Sat, 20 Nov 2004 19:19:42 +0200 From: "Eli Zaretskii" > Date: Sat, 20 Nov 2004 13:39:09 +0100 (CET) > From: Mark Kettenis > > Only a tiny fraction of the code, but it's a step into the right > direction. I think changes like these are wrong: > - case N_STSYM: /* Static symbol in data seg */ > - case N_LCSYM: /* Static symbol in BSS seg */ > - case N_ROSYM: /* Static symbol in Read-only data seg */ > + case N_STSYM: /* Static symbol in data segment. */ > + case N_LCSYM: /* Static symbol in BSS segment. */ > + case N_ROSYM: /* Static symbol in read-only data segment. */ The text in these comments does not constitute a full sentence, and so adding a period at the end is not the right change. The right way to fix this, IMHO, is to lower-case the first letter of the comment, like this: The coding standards say: "Also, please write complete sentences and capitalize the first word." Now indeed it is debatable whether the comments above are complete sentences; there's no verb in them. But these comments feel very sentence-like. Anyway, I was aiming for some consistency here. case N_STSYM: /* static symbol in data segment */ There are numerous other instances of similar changes, and IMHO they all are wrong. This one looks particularly incorrect after the change: > + case N_NOMAP: /* No map? (Ultrix). */ Some of the other changes simply reformat comments to break the line at a different column. Do we have a canonical column number for that, and if we do, what is its value? I always consider the GNU indentation style provided by emacs to be an implementation of the canonical formatting style. The canonical column therefore would be 32. But again, my intent here was consistency here. The useage was very inconsistent makeing the code difficult to read. Mark