Re: [commit] Convert COERCE_* to functions

[Mark Kettenis <mark.kettenis@xs4all.nl>]

   Date: Thu, 11 Nov 2004 21:37:45 +0200
   From: "Eli Zaretskii" <eliz@gnu.org>

   > Date: Thu, 11 Nov 2004 11:36:57 -0500
   > From: Andrew Cagney <cagney@gnu.org>
   > Cc: gdb-patches@sources.redhat.com
   > 
   > > 1) Can you tell the reason for these changes?
   > > 
   > > 2) Personally, I think that
   > > 
   > >      foo = foobar (foo);
   > > 
   > >    is not a good style of C programming.
   > 
   > opaque `struct value'
   > http://sources.redhat.com/ml/gdb/2004-11/msg00010.html

   Thanks.  Perhaps it would help in the future to post the URL with the
   patch.

Come on Eli.  This patch came a few days after Andrew announced he was
going to make `struct value' opaque.

   > Converting a macro to a function has for a long time been considered 
   > obvious.

   I don't think it's obvious, but if I'm the only one, let's codify that
   where we say what falls under the ``obvious'' rule.

Codifying this kind of details is stupid.  Codifying the general rules
should be enough.

Mark