From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28022 invoked by alias); 8 Nov 2004 20:44:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27527 invoked from network); 8 Nov 2004 20:43:51 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 8 Nov 2004 20:43:51 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id iA8Khml0006937; Mon, 8 Nov 2004 21:43:48 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id iA8Khlet087941; Mon, 8 Nov 2004 21:43:47 +0100 (CET) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id iA8Khl6M087938; Mon, 8 Nov 2004 21:43:47 +0100 (CET) Date: Mon, 08 Nov 2004 20:44:00 -0000 Message-Id: <200411082043.iA8Khl6M087938@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: schwab@suse.de CC: gdb-patches@sources.redhat.com In-reply-to: (message from Andreas Schwab on Mon, 08 Nov 2004 11:50:42 +0100) Subject: Re: [COMMIT] Convert *BSD/m68k to use target vector inheritance References: <200411072131.iA7LVPC6065067@elgar.sibelius.xs4all.nl> X-SW-Source: 2004-11/txt/msg00136.txt.bz2 From: Andreas Schwab Date: Mon, 08 Nov 2004 11:50:42 +0100 Mark Kettenis writes: > @@ -223,6 +223,13 @@ void _initialize_m68kbsd_nat (void); > void > _initialize_m68kbsd_nat (void) > { > + struct target_ops *t; > + > + t = inf_ptrace_target (); > + t->to_fetch_registers = vaxbsd_fetch_inferior_registers; > + t->to_store_registers = vaxbsd_store_inferior_registers; Are you sure you didn't want to use m68kbsd_fetch_inferior_registers and m68kbsd_store_inferior_registers here? Aargh. Looks like I didn't check in what I tested. Here's something that should work better. Thanks for spotting this. Mark Index: ChangeLog from Mark Kettenis * m68kbsd-nat.c: Include "inf-ptrace.h". (_initialize_m68kbsd_nat): Fix pasto. * Makefile.in (m68kbsd-nat.o): Update dependencies. Index: m68kbsd-nat.c =================================================================== RCS file: /cvs/src/src/gdb/m68kbsd-nat.c,v retrieving revision 1.5 diff -u -p -r1.5 m68kbsd-nat.c --- m68kbsd-nat.c 7 Nov 2004 21:31:19 -0000 1.5 +++ m68kbsd-nat.c 8 Nov 2004 20:39:23 -0000 @@ -30,6 +30,7 @@ #include #include "m68k-tdep.h" +#include "inf-ptrace.h" static int m68kbsd_gregset_supplies_p (int regnum) @@ -226,8 +227,8 @@ _initialize_m68kbsd_nat (void) struct target_ops *t; t = inf_ptrace_target (); - t->to_fetch_registers = vaxbsd_fetch_inferior_registers; - t->to_store_registers = vaxbsd_store_inferior_registers; + t->to_fetch_registers = m68kbsd_fetch_inferior_registers; + t->to_store_registers = m68kbsd_store_inferior_registers; add_target (t); /* Support debugging kernel virtual memory images. */ Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.659 diff -u -p -r1.659 Makefile.in --- Makefile.in 7 Nov 2004 21:33:29 -0000 1.659 +++ Makefile.in 8 Nov 2004 20:39:27 -0000 @@ -2179,7 +2179,8 @@ m68hc11-tdep.o: m68hc11-tdep.c $(defs_h) $(arch_utils_h) $(regcache_h) $(reggroups_h) $(target_h) \ $(opcode_m68hc11_h) $(elf_m68hc11_h) $(elf_bfd_h) m68kbsd-nat.o: m68kbsd-nat.c $(defs_h) $(gdbcore_h) $(inferior_h) \ - $(regcache_h) $(gdb_assert_h) $(m68k_tdep_h) $(bsd_kvm_h) + $(regcache_h) $(gdb_assert_h) $(m68k_tdep_h) $(inf_ptrace_h) \ + $(bsd_kvm_h) m68kbsd-tdep.o: m68kbsd-tdep.c $(defs_h) $(arch_utils_h) $(osabi_h) \ $(regcache_h) $(regset_h) $(gdb_assert_h) $(gdb_string_h) \ $(m68k_tdep_h) $(solib_svr4_h)