From: Mark Kettenis <kettenis@gnu.org>
To: gdb-patches@sources.redhat.com, cagney@gnu.org, drow@false.org
Subject: [COMMIT] Avoid unnecessary indirection when decoding DWARF CFI
Date: Fri, 05 Nov 2004 22:37:00 -0000 [thread overview]
Message-ID: <200411052237.iA5MbWLG015153@elgar.sibelius.xs4all.nl> (raw)
This fixes the problems for me. It's better to skip the indirection
here anyway, since it will save a memory read and thus avoids any
problems with that.
Committed,
Mark
P.S. Andrew, can you test it on your systems. I still like to get
this on the branch since it fixes a nasty problem on SPARC. But it
can wait until 6.3.1.
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* dwarf2-frame.c (decode_frame_entry_1): Avoid indirection when
skipping a personality routine in a CIE augmentation.
Index: dwarf2-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2-frame.c,v
retrieving revision 1.42
diff -u -p -r1.42 dwarf2-frame.c
--- dwarf2-frame.c 5 Nov 2004 15:16:44 -0000 1.42
+++ dwarf2-frame.c 5 Nov 2004 22:30:07 -0000
@@ -1380,8 +1380,8 @@ decode_frame_entry_1 (struct comp_unit *
/* "P" indicates a personality routine in the CIE augmentation. */
else if (*augmentation == 'P')
{
- /* Skip. */
- unsigned char encoding = *buf++;
+ /* Skip. Avoid indirection since we throw away the result. */
+ unsigned char encoding = (*buf++) & ~DW_EH_PE_indirect;
read_encoded_value (unit, encoding, buf, &bytes_read);
buf += bytes_read;
augmentation++;
next reply other threads:[~2004-11-05 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 22:37 Mark Kettenis [this message]
2004-11-08 16:47 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411052237.iA5MbWLG015153@elgar.sibelius.xs4all.nl \
--to=kettenis@gnu.org \
--cc=cagney@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox