Re: [RFA]: Watchpoints per thread patch

Daniel Jacobowitz
2004-11-09T20:50:41Z

On Tue, Nov 09, 2004 at 03:48:32PM -0500, Jeff Johnston wrote:
> Daniel Jacobowitz wrote:
> >On Tue, Nov 09, 2004 at 02:06:07PM -0500, Jeff Johnston wrote:
> >
> >>Time out here for a second. I have been modifying this patch according
> >>to "your" comments. I have had a design that had no observers and one
> >>that kept the observation isolated to the linux code.
> >
> >
> >The design without observers had plenty of other problems, e.g. it also
> >broke remote debugging.
> >
> >My suggestion about putting the observer in add_thread was a bad one.
> >I've never claimed to be an infallible lord of development. A
> >new_thread observer does indeed belong in add_thread, but is not
> >suitable for your use; and I didn't understand why until later.
> >
>
> Fair enough, but it was certainly uncalled for to categorize my patch(s) as
> "crap" as I was attempting to implement your suggested changes.

I think it was entirely called for; it just reflected as much upon my
suggestion as on your patch. I apologize for giving bad advice.

--
Daniel Jacobowitz